Repository navigation
Do not record a usage for a function-like macro name without ( - #759
Open
JayToltTech wants to merge 1 commit into
Open
JayToltTech wants to merge 1 commit into
JayToltTech wants to merge 1 commit into
Conversation
expand() added the use location to the usage list before checking whether a function-like macro is followed by (, so `int F = 1;` with F defined as a function-like macro was reported as a usage of F although nothing is expanded. Record the usage after that check.
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Macro::expand()adds the use location tousageListbefore it checks whether a function-like macro is followed by(. So with#define F(x) x, theFinint F = 1;shows up in the macro usage list even though nothing is expanded there.Came up in cppcheck-opensource/cppcheck#9018, where cppcheck uses the usage list to apply
cppcheck-suppress-macroand that phantom usage suppressed a realzerodiv. That PR filters it on the cppcheck side for now.This moves the
usageList.emplace_backbelow the no-arguments check.__COUNTER__still sees its usage before it reads the count, and builtins aren't function-like so they're unaffected.tokenMacro16covers it. testrunner and run-tests.py pass on macOS arm64. I also dropped the same change into cppcheck'sexternals/simplecpplocally and its testrunner passes.runformatwith uncrustify 0.80.1 makes no changes.