Repository navigation
Conversation
- In a terminal, drx init is a guided run: it asks for the starter, the layout and the engine, and marks each step as it finishes. - drx with no command opens a menu, and the module commands offer a list to pick from. - Output in a terminal shows the Druxt wordmark, in colour. A command to repeat is printed quoted, ready to paste. - `--no-interactive`, DRX_NO_INTERACTIVE=1, CI and a missing terminal each turn the prompts off. The tests run init, info and the module commands under each of the four. - The pack check runs an unattended init with the installed binary.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 59 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Decipher
force-pushed
the
feature/05-interactive
branch
from
November 18, 2026 06:51
9c93273 to
838cd00
Compare
The shell quoting the `cd` line uses is the function this branch already has for a command to repeat, so the file stays as it is here.
- `drx init` with no directory and nobody to ask said there was no terminal to ask on, also when it ran in one with the questions turned off. It now names the cause: `--no-interactive`, `DRX_NO_INTERACTIVE` or `CI` when one of them turned the questions off, `--json` when that did, and the missing terminal only when there is none. - The context of a command holds what turned the questions off, in `questionsOff`.
…om the branch below
`drx module --json list` printed the text table, and `drx module --module-registry <url> list` read the public registry. An option between `module` and its command was dropped without a word. - Such an option is now moved to after the command's name before the arguments are parsed, so it does what the same option does there. One the command does not have is refused by the command. - With `--json` before the command, a failure is one JSON document on stdout as well. - A guided `init --force` into a directory that holds files says in its summary that the files of every engine are kept.
`drx module --type contrib list` failed with "Unknown command contrib", and `drx --json info` printed text. An option before a command was read by the options of the group alone, and one before a top-level command was dropped. - An option before the name of a command is now moved to after it, with its value, whether that is the next argument or follows `=`. The command is the one the arguments name once each option is read as that command defines it. - This holds before a top-level command as well, so `drx --json info` prints JSON and `drx --json module list` does too. - An option the command does not have is refused there as well. - `--help` after such an option shows the usage of the command named.
… its setup ran An install's own banner and next steps appeared in the middle of the run and disagreed with the steps init printed. The output is kept now, and its end is in the error when the install fails. A starter's entry can say how to tell that its install ran the setup. When that check does not pass, the setup stays among the next steps. An engine has a name to show in the prompt and a separate phrase for what it needs. The small header is printed once for each run, after the menu too. The bundled registry is announced in one line. A site that would sit inside a git repository gets a warning.
…had its own Every site made from one starter had the same DDEV or Lando project name, so a second site was the first one's project to the engine, with its database and its address. init now writes a name made from the site's directory in the files the starter lists, and in the backend URL.
With the none engine nothing sets the backend up, and the quickstart does not start until its OAuth client ID is in the site's environment file. A starter's entry can list such lines, and init prints them as notes.
… name The name was trimmed with regular expressions that backtrack on a long run of hyphens. The end-to-end test now expects the site's own project name in the Lando file and in the backend URL.
"Show a module" and "Show this project" did not say what would be shown. The choices are now "View a module's details" and "View this project's details", which is the word npm, pnpm and the GitHub CLI use for reading one item. The help text of the module commands follows.
The entries gained fields at this level, so a build from it has to prefer its bundled copy over a published registry that does not have them yet.
The quickstart starter's note that `npm run dev` starts the backend again was printed after every install, whatever engine was chosen. It is now a note of the php engine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
drx initis a guided run. It asks for the starter, the layout and the engine, shows what it will do, and marks each step as done.drxwith no command opens a menu. The module commands offer a list to pick a module from.--no-interactive,DRX_NO_INTERACTIVE=1,CIand a missing terminal each turn the prompts off. A test runsinit,infoand the module commands under each of the four.drx initwith the installed binary.Why
A first run should not need the flags learned. A script or a pipeline needs the opposite: no prompt, ever, and the same result from flags alone. Both now hold, and the tests pin the second.
How it was checked
npm run lintandnpm run typecheckpassnpm testpasses, and coverage did not dropRun from a clean
npm ci: eachrun:line of the workflow's lint and test jobs,yamllint,actionlintandnpm run build.npm testran 608 tests, above the floor. The pack step ran as the workflow has it, and now ends withdrx init pack-site --yes --no-interactive --jsonfrom the installed binary.Not covered yet