Repository navigation
Fix dead documentation links - #3838
Open
farisbasha wants to merge 1 commit into
Open
farisbasha wants to merge 1 commit into
farisbasha wants to merge 1 commit into
Conversation
The README "Advanced Usage" link points at /advanced/, which is a 404 since the advanced docs were split into separate pages. Point it at the first page of that section (advanced/clients/). Also update three other links that now return 404: - .github/CONTRIBUTING.md proxy and SSL anchors (same targets docs/contributing.md already uses) - Authlib HTTPX client docs (moved under oauth2/client/http/) - everything.curl.dev .netrc page (now needs the .html suffix)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Four documentation links return 404:
README.md("Advanced Usage")https://www.python-httpx.org/advanced/https://www.python-httpx.org/advanced/clients/(first page of the Advanced section inmkdocs.yml).github/CONTRIBUTING.mdadvanced/#http-proxying,advanced/#ssl-certificatesadvanced/proxies/#http-proxies,advanced/ssl/(the same targetsdocs/contributing.mdalready uses)docs/third_party_packages.md(Authlib)https://docs.authlib.org/en/latest/client/httpx.htmlhttps://docs.authlib.org/en/latest/oauth2/client/http/httpx.htmldocs/advanced/authentication.md(.netrc)https://everything.curl.dev/usingcurl/netrchttps://everything.curl.dev/usingcurl/netrc.htmlThe README one also shows up on the PyPI project page.
Checked with
curl -sL -o /dev/null -w '%{http_code}': every old URL returns 404, every new one returns 200, and the#http-proxiesanchor exists on the proxies page.Checklist