Repository navigation
Allow guzzlehttp/psr7 ^3.0 and drop abandoned http-interop/http-factory-guzzle - #214
Open
RobertoNegro wants to merge 1 commit into
Open
RobertoNegro wants to merge 1 commit into
RobertoNegro wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
http-interop/http-factory-guzzleis abandoned and pinsguzzlehttp/psr7to^1.7 || ^2.0.That single constraint blocks the whole downstream chain from
psr7 ^3.0and therefore fromguzzlehttp/guzzle ^8.0, which requirespsr7 ^3.4.The package does not need it: no class in src/ references
http-interopdirectly since 2019. The PSR-17 factory is resolved at runtime viaphp-http/discovery, andguzzlehttp/psr7itself providespsr/http-factory-implementation, so discovery keeps working with the interop adapter gone.Test evidence
Full suite (
vendor/bin/pest: 41 tests, 91 assertions) on a clean install withouthttp-interopinstalled:psr7 3.5.0+guzzle 8.5.2→ ✅ 41 passed, composer audit cleanpsr7 2.13.4+guzzle 7.16.3→ ✅ 41 passed (no regression for v2 users)