Repository navigation
Conversation
Since policy denials are forwarded, upstreamMetadataStatus built a fetch.StatusError for every status, so each failed fetch logged up to 4 KiB of a 5xx or 429 error page. Those return the plain "upstream returned N" error again, as registries' fetcher does.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 32 minutes. View limit details
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
Follow-up to #745, as suggested there.
upstreamMetadataStatusbuilt afetch.StatusErrorfor every status other than 200 and 404, so each "metadata fetch failed" log line for an upstream 5xx or 429 carried up to 4 KiB of its error page. Server errors and 429 now return the plainupstream returned Nerror again, as registries' fetcher keepsStatusErroronly for the other statuses. 403, 409 and the rest still keep their body, so policy denials are forwarded as before.TestUpstreamMetadataStatusKeepsServerErrorsShortcovers both sides.Summary by CodeRabbit