Repository navigation
Run on Windows as on Linux and macOS: Python resolution, portability check, Windows CI - #5
Merged
Merged
Conversation
…check, Windows CI
- A bare python3 or python in an extractor or prepare command runs the machine's
Python 3 (python3, python, then py -3, checked by --version), so the scaffolded
["python3", ...] and the django-schema default work on a standard Windows
install. doctor and the environment report use the same resolution. The Python
suites no longer skip Windows.
- npm run check:portability flags OS assumptions in shipped code (POSIX shells
and paths, shell strings, bare npm/python launchers, path.posix on native
paths, '/'-split native paths, LF-only file text, resolved-path equality,
Path::join("a/b"), POSIX-only npm scripts), with reasoned exceptions in
.portability.yaml. Fixes what it found: mixed-separator Path::join calls and
entry-point checks by path equality (now import.meta.main).
- CI: windows-node (Node suites, installed proof, file-system checks),
windows-integration (CLI browser suite, a renderer smoke test, VS Code smoke
test, the Action end to end), browser-macos (renderers in WebKit), and the
Action end to end on Linux and macOS too.
- Test harnesses: the CLI path gets .exe on Windows, npm runs through
npm_execpath (Node refuses .cmd without a shell), and POSIX-only tests name
their reason.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
- init --renderer custom wrote file://?/C:/... into the renderer's package.json on Windows: canonical paths carried the \\?\ verbatim prefix. Use the extractor SDK's canonical() and compare drive paths whichever way they're spelled. - Vite refuses Windows 8.3 short names (RUNNER~1 in the runner's temporary directory): the Vite suites use the native realpath. - doctor looks up an extractor's program in its own function (complexity). - windows-integration removes the runner image's python3 before the Action's end-to-end run, as a standard Windows install has none. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…ative paths with sep - workspaces.mjs --keep-going runs every workspace's task and then names each that failed. - The portability rule native-path-slash also flags a native path extended with '/'. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
- The Action's snapshots passed --trust with show --from, which the CLI refuses, so trust: true never rendered snapshots. Saved documents run no repository code; the flag is gone. - The viewer header's ascender room (0.35em above the trimmed cap height) was short of Segoe UI's ascent (0.38em): 0.4em now, with the matching margin. - check-pack ran Git Bash's GNU tar on Windows, which reads C: as a remote host; it uses %SystemRoot%\System32\tar.exe. The portability rule flags a bare tar. - Tests: import() and --import take file URLs, not native paths; the Inspector harness puts Git's own directory on PATH on Windows instead of a symlink; the viewer spec waits for the page to apply the agent's state and for the viewer to exit before cleanup; the scaffold test expects the non-verbatim root; the snapshot test passes the variables the CLI finds Chrome with; POSIX-only checks (execute bits, /bin/sh gh and git stand-ins) are skipped with their reason. - CI: the CLI's Node suites time out per test; windows-node gets 90 minutes; browser-macos runs in two shards. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…suites - The SDK and TypeScript helper tests imported native paths, which Windows reads as a d: URL scheme. - The VS Code smoke test reports what the Details panel shows when the evidence doesn't appear. - windows-integration runs the VS Code smoke test and the Action end to end whatever the steps before them did; windows-node runs the CLI's Node suites one file at a time with TAP output, a per-test timeout and a forced exit. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…st fixes - serve --stdio's initialize named the repository \\?\C:\...: it uses the extractor SDK's canonical(), as clients compare it with folders they have open. - CLI tests: fixture repositories are removed after the file's tests, once the processes their tests started have stopped (Windows refuses to remove a running process's directory); the MCP test passes the variables the CLI finds Chrome with on Windows. - The installed proof runs the .NET helper on Linux and macOS only, for now: on Windows dotnet fails in the extractor environment (runner-coverage.md). - windows-integration gives VS Code a desktop-sized display, and accepts the Microsoft Store's python3 alias, which runs no Python, after removing python3. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…eports motion Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…r in separators and drive-letter case Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes sure Projections works on Windows, macOS and Linux, and adds a check that catches OS-specific assumptions as they're written.
Python on Windows
projections init --language pythonscaffolded["python3", ...], and the django-schema extractor defaults topython3. A standard python.org Windows install has nopython3. Now a barepython3orpythonin an extractor or prepare command runs the machine's Python 3: the name as written, then the other name, thenpy -3. Each is checked by--version, which turns away Python 2 and the Microsoft Store alias. Containers run the command as written.doctorand the environment report use the same resolution. The three Python suites that were ignored on Windows now run there, and the Action's end-to-end check on Windows runs apython3extractor with onlypython,pyand the Store alias on PATH.Portability check
npm run check:portability(part ofnpm run checkand the tools gates) reads shipped code:packages/without tests, fixtures and snapshots, plus the Action. Rules:posix-shell,shell-stringbare-launcher(npm, npx,.cmdshims, python3, tar),rust-bare-launcherposix-path-module,native-path-slashfile-text-lf,path-equality,rust-path-slashnpm-script-posixExceptions go in
.portability.yamlwith a reason each; a stale entry fails the check. The rules have tests. Docs are indocs/maintainers/runner-coverage.md#platform-coverageand CONTRIBUTING.CI
windowswindows-nodewindows-nodebrowser(all)windows-integration: CLI suite and a renderer smoke testbrowser(all)browser-macos(renderers, 2 shards)windows-integrationuses: ./)windows-integrationEvery Windows skip names its reason.
Found and fixed
python3is missing on standard Windows installs.snapshotswithtrust: truepassed--trusttoshow --from, which refuses it, so trusted snapshots never rendered (every OS).init --renderer customwrotefile:C:/?/C:/...on Windows (\\?\verbatim paths).serve --stdio: reported the repository as\\?\C:\...on Windows.Path::join("a/b")produced mixed-separator paths (7 places); two entry-point checks compared paths with===and now useimport.meta.main.check-pack: ran Git Bash's GNU tar on Windows, which readsC:as a remote host.npm.cmdwithout a shell, which Node refuses (EINVAL), and missing.exeon the CLI path;which,/bin/shstand-ins and execute bits;import()and--import;Open, not fixed here
dotnetfails in the extractor environment (PATH, SystemRoot, DOTNET_*): "An issue was encountered verifying workloads". Fixing it likely means giving extractors Windows' machine locations (ProgramData, ProgramFiles), which changes the documented extractor-environment contract. The installed proof runs the .NET helper on Linux and macOS only, with the reason stated.starter-devHMR (also fails onmain), Linux WebKit timeouts, ahost/corereduced-motion load race, and one intermittent comparator Wasm trap in macOS WebKit (call_indirectsignature mismatch inring-pixelsapi, 1 of 5 runs; it passed on retry), which may be a WebKit JIT bug and deserves its own issue.