Repository navigation
fix(bigquery): validate universe domain on resumable upload RPCs - #15133
Open
jinseopkim0 wants to merge 1 commit into
Open
jinseopkim0 wants to merge 1 commit into
jinseopkim0 wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds validateRPC() checks to the openSkipExceptionTranslation and writeSkipExceptionTranslation methods in HttpBigQueryRpc.java. It also introduces a new suite of unit tests in HttpBigQueryRpcTest.java to verify that these methods, along with open and write, correctly fail with a BigQueryException (401 status code) when configured with a mismatched universe domain. I have no feedback to provide as there are no review comments.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
HttpBigQueryRpc.openSkipExceptionTranslationandwriteSkipExceptionTranslationomittedvalidateRPC(), allowing resumable upload requests with mismatched universe domain credentials to bypass client-side universe domain validation.Solution: Call
validateRPC()at the start of both methods and add unit tests verifying mismatched universe domain rejection before any HTTP request is executed.b/588887572