Skip to content

fix(bigquery): validate universe domain on resumable upload RPCs - #15133

Open
jinseopkim0 wants to merge 1 commit into
mainfrom
fix/bigquery-validate-rpc-upload
Open

jinseopkim0 wants to merge 1 commit into
mainfrom
fix/bigquery-validate-rpc-upload

Conversation

@jinseopkim0

Copy link
Copy Markdown
Contributor

Problem: HttpBigQueryRpc.openSkipExceptionTranslation and writeSkipExceptionTranslation omitted validateRPC(), allowing resumable upload requests with mismatched universe domain credentials to bypass client-side universe domain validation.

Solution: Call validateRPC() at the start of both methods and add unit tests verifying mismatched universe domain rejection before any HTTP request is executed.

b/588887572

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds validateRPC() checks to the openSkipExceptionTranslation and writeSkipExceptionTranslation methods in HttpBigQueryRpc.java. It also introduces a new suite of unit tests in HttpBigQueryRpcTest.java to verify that these methods, along with open and write, correctly fail with a BigQueryException (401 status code) when configured with a mismatched universe domain. I have no feedback to provide as there are no review comments.

@jinseopkim0
jinseopkim0 marked this pull request as ready for review November 21, 2026 22:32
@jinseopkim0
jinseopkim0 requested review from a team as code owners November 21, 2026 22:32
@jinseopkim0
jinseopkim0 requested a review from lqiu96 November 21, 2026 22:32

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant