Repository navigation
fix(spanner): recompute default host on toBuilder().setUniverseDomain() - #15134
Open
sakthivelmanii wants to merge 1 commit into
Open
sakthivelmanii wants to merge 1 commit into
sakthivelmanii wants to merge 1 commit into
Conversation
Calling toBuilder().setUniverseDomain(...) on a built SpannerOptions instance previously retained the materialized default host (https://spanner.googleapis.com) because Builder(SpannerOptions) copied options.getHost() and ServiceOptions.Builder(ServiceOptions) copied the resolved host. Track only the explicitly configured host in SpannerOptions and restore that value in Builder(SpannerOptions), allowing default hosts to be recomputed via getDefaultHost() when the universe domain changes while preserving explicit custom hosts, emulator hosts, and Omni hosts.
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates SpannerOptions to track the explicitly configured host separately from the materialized default host. This ensures that subsequent calls to setUniverseDomain() correctly recompute the default host when using toBuilder(). Additionally, several unit tests were added to verify the behavior of toBuilder() under various configurations of universe domains, custom hosts, and emulator hosts. I have no feedback to provide.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling toBuilder().setUniverseDomain(...) on a built SpannerOptions instance previously retained the materialized default host (https://spanner.googleapis.com) because Builder(SpannerOptions) copied options.getHost() and ServiceOptions.Builder(ServiceOptions) copied the resolved host.
Track only the explicitly configured host in SpannerOptions and restore that value in Builder(SpannerOptions), allowing default hosts to be recomputed via getDefaultHost() when the universe domain changes while preserving explicit custom hosts, emulator hosts, and Omni hosts.