Skip to content

fix(logging): propagate universe domain and resolve default endpoint via GAX - #15136

Draft
jinseopkim0 wants to merge 2 commits into
mainfrom
fix/logging-universe-domain-propagation
Draft

jinseopkim0 wants to merge 2 commits into
mainfrom
fix/logging-universe-domain-propagation

Conversation

@jinseopkim0

@jinseopkim0 jinseopkim0 commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor

b/588887355

Propagate universeDomain to LoggingSettings and let GAX resolve the default endpoint from the universe domain.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors GrpcLoggingRpc by extracting the creation of LoggingSettings into a dedicated createLoggingSettings helper method and adds corresponding unit tests to verify universe domain propagation and endpoint resolution. A review comment points out that bypassing GrpcTransportOptions.setUpChannelProvider when using the default host discards custom channel configurations from options. It suggests calling setUpChannelProvider and clearing the endpoint on the resulting provider instead to preserve these configurations.

@jinseopkim0

Copy link
Copy Markdown
Contributor Author

@gemini-code-assist review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors GrpcLoggingRpc to propagate the universeDomain from LoggingOptions to LoggingSettings and defer endpoint resolution to GAX when the default host is used, accompanied by new unit tests in GrpcLoggingRpcTest. However, bypassing GrpcTransportOptions.setUpChannelProvider when the default host is used discards other custom transport configurations specified in LoggingOptions. It is recommended to retrieve the channel provider using setUpChannelProvider and then clear the endpoint if the default host is used, ensuring other custom configurations are preserved.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant