Repository navigation
fix(logging): propagate universe domain and resolve default endpoint via GAX - #15136
jinseopkim0 wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request refactors GrpcLoggingRpc by extracting the creation of LoggingSettings into a dedicated createLoggingSettings helper method and adds corresponding unit tests to verify universe domain propagation and endpoint resolution. A review comment points out that bypassing GrpcTransportOptions.setUpChannelProvider when using the default host discards custom channel configurations from options. It suggests calling setUpChannelProvider and clearing the endpoint on the resulting provider instead to preserve these configurations.
|
@gemini-code-assist review |
There was a problem hiding this comment.
Code Review
This pull request refactors GrpcLoggingRpc to propagate the universeDomain from LoggingOptions to LoggingSettings and defer endpoint resolution to GAX when the default host is used, accompanied by new unit tests in GrpcLoggingRpcTest. However, bypassing GrpcTransportOptions.setUpChannelProvider when the default host is used discards other custom transport configurations specified in LoggingOptions. It is recommended to retrieve the channel provider using setUpChannelProvider and then clear the endpoint if the default host is used, ensuring other custom configurations are preserved.
b/588887355
Propagate
universeDomaintoLoggingSettingsand let GAX resolve the default endpoint from the universe domain.