Repository navigation
fix(cli): add --next/--prev to source, destination and connection list - #501
Open
pcbeingused333 wants to merge 1 commit into
Open
pcbeingused333 wants to merge 1 commit into
pcbeingused333 wants to merge 1 commit into
Conversation
The text output of these commands tells the user to pass --next to get the next page, but the flag did not exist. Add --next/--prev and forward the cursors to the API, as event list and request list already do. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #366 (point 1, pagination; points 2 and 3 are left open).
hookdeck gateway source list,destination listandconnection listprint "To get the next page: ... --next " when more results exist, but none of them accepted--next(or--prev), so the printed command failed withunknown flag: --next.event listandrequest listalready have the flags.The three commands now take
--nextand--prevand send them to the API as thenext/prevquery parameters, the same wayevent listdoes. This only covers the pagination point of the issue.TestResourceListSendsPaginationCursorsruns each list command against a stub API and checks that the cursors reach the query string. It fails on main withunknown flag: --nextand passes with this change.This change was prepared with AI assistance.