Repository navigation
fix(outpost): clarify and display included attempt responses - #502
Open
pcbeingused333 wants to merge 1 commit into
Open
pcbeingused333 wants to merge 1 commit into
pcbeingused333 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #449
The attempt help promises the destination response even though the API only returns it when
response_datais explicitly included. The MCP include description also omits that option, and the CLI renderer discards response data returned by the API.Clarify the CLI help and MCP get action description, advertise all supported include values in the MCP schema, and render non-empty response data as indented JSON in the attempt output. Update the corresponding reference text. This follows the issue's second option and preserves the existing API request defaults.
Testing and validation
GOPROXY=off go test ./pkg/cmd/ ./pkg/outpost/mcp/ -run 'OutpostAttempt|Attempts' -count=1: three regression tests fail on main and pass with the fix. Reverting each implementation file independently reproduces the expected failures.GOPROXY=off go vet ./...: passes.-tags=outpost) was not run: it needsHOOKDECK_CLI_OUTPOST_TESTING_API_KEY.AI assistance: this change and its regression tests were prepared with Codex.