Skip to content

fix(outpost): clarify and display included attempt responses - #502

Open
pcbeingused333 wants to merge 1 commit into
hookdeck:mainfrom
pcbeingused333:fix/c4007-attempt-response
Open

pcbeingused333 wants to merge 1 commit into
hookdeck:mainfrom
pcbeingused333:fix/c4007-attempt-response

Conversation

@pcbeingused333

Copy link
Copy Markdown
Contributor

Fixes #449

The attempt help promises the destination response even though the API only returns it when response_data is explicitly included. The MCP include description also omits that option, and the CLI renderer discards response data returned by the API.

Clarify the CLI help and MCP get action description, advertise all supported include values in the MCP schema, and render non-empty response data as indented JSON in the attempt output. Update the corresponding reference text. This follows the issue's second option and preserves the existing API request defaults.

Testing and validation

  • Regression tests cover included, absent and empty response data, CLI help, and the published MCP tool schema.
  • GOPROXY=off go test ./pkg/cmd/ ./pkg/outpost/mcp/ -run 'OutpostAttempt|Attempts' -count=1: three regression tests fail on main and pass with the fix. Reverting each implementation file independently reproduces the expected failures.
  • GOPROXY=off go vet ./...: passes.
  • The outpost acceptance test (-tags=outpost) was not run: it needs HOOKDECK_CLI_OUTPOST_TESTING_API_KEY.

AI assistance: this change and its regression tests were prepared with Codex.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

outpost attempt get does not return the destination response its help describes

1 participant