Repository navigation
fix(cli): keep cause and meta when listing a request's ignored events - #503
Open
pcbeingused333 wants to merge 1 commit into
Open
pcbeingused333 wants to merge 1 commit into
pcbeingused333 wants to merge 1 commit into
Conversation
GetRequestIgnoredEvents decoded the response into EventListResponse, which has no cause or meta, so the CLI and the MCP list_ignored action dropped the fields that say why an event was ignored. Decode into a new IgnoredEvent type and print the cause instead of the always-empty status.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #430
Cause.
GET /requests/{id}/ignored_eventsreturnsid, team_id, webhook_id, cause, request_id, meta, created_at, butGetRequestIgnoredEventsdecoded it intoEventListResponse/Event, which has nocauseormeta. Sohookdeck gateway request ignored-eventsand the MCPlist_ignoredaction dropped the only fields that say why an event was ignored (FILTEREDvsCLI_DISCONNECTED) and emitted emptystatus/source_id/destination_id.Fix. Add an
IgnoredEvent/IgnoredEventListResponsetype matching theIgnoredEventschema in the 2026-09-01 OpenAPI document, decode into it, and have the MCP tool return it. The plain-text output now prints the cause instead of an always-empty status.Test.
TestGetRequestIgnoredEventsKeepsCauseAndMetaserves a page with a FILTERED event (metais an array), a TRANSFORMATION_FAILED event (metais an object) and a CLI_DISCONNECTED event (metanull), and checkscauseandmetasurvive and that nostatuskey is emitted. It does not build on main and passes with the change; thepkg/hookdeck,pkg/gateway/mcpandpkg/cmdsuites pass.Reproduction.
hookdeck gateway request ignored-events <request-id> --output jsonon a request with a filtered connection:causeandmetaare missing from the output.This PR was prepared with AI assistance (Claude Code) and the contributor is responsible for the change.