Repository navigation
Conversation
Users\Keys requested /users/keys for the authenticated user's keys,
which is the key list of a user named "keys". The endpoints are
/user/keys and /user/keys/{key_id}. Followers::checkUserFollowing()
requested /user/{user}/following/{target} instead of
/users/{user}/following/{target}. The tests asserted the same wrong
paths.
GitHub has no endpoint to update a key, so deprecate Keys::edit().
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Users\Keys::getList(),get(),create(),edit()anddelete()requested/users/keys[/{id}]. That is not the authenticated user's key list but the public keys of a user namedkeys. The endpoints are/user/keysand/user/keys/{key_id}.Users\Followers::checkUserFollowing()requested/user/{user}/following/{target}instead of/users/{user}/following/{target}.Keys::edit()can never work. It is deprecated (runtime deprecation, removal in 5.0; addssymfony/deprecation-contracts^2|^3). Delete the key and create a new one instead.Testing Instructions
Tests/Package/Users/KeysTest.phpandFollowersTest.phpasserted the same wrong paths; they now assert the documented ones and fail before the change (7 failures).KeysTest::testEditalso expects the deprecation.Documentation Changes Required
docs/overview.md: short section on the authenticated user's keys and the deprecatededit(). The 5.x removal ofKeys::edit()follows in a separate PR.🤖 Generated with Claude Code