Skip to content

[4.x] Request the repository issue events in Issues\Events::getListRepository() - #90

Open
Hackwar wants to merge 1 commit into
joomla-framework:4.x-devfrom
Hackwar:4.x-issue-events-repository
Open

Hackwar wants to merge 1 commit into
joomla-framework:4.x-devfrom
Hackwar:4.x-issue-events-repository

Conversation

@Hackwar

@Hackwar Hackwar commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

Summary of Changes

Issues\Events::getListRepository($owner, $repo, $issueId, $page, $limit) is documented as "List events for a repository", but requested /repos/{owner}/{repo}/issues/{issueId}/comments — the comments of one issue. It now requests /repos/{owner}/{repo}/issues/events with paging.

The $issueId parameter has no meaning for that endpoint. It stays in place (now optional) so $page/$limit keep their positions, is ignored, and triggers a deprecation when passed (removal in 5.0; adds symfony/deprecation-contracts ^2|^3). Behaviour change in 4.x: callers that relied on getting issue comments from this method get issue events now; Issues\Comments::getList() is the method for comments.

Testing Instructions

Tests/Package/Issues/EventsTest.php: testGetListRepository asserts the events path with paging; testGetListRepositoryWithIssueId expects the deprecation. Both fail before the change.

Documentation Changes Required

docs/overview.md: short section on the method and the deprecated parameter. The 5.x removal of the parameter follows with the other 5.0 removals.

🤖 Generated with Claude Code

…ry()

getListRepository() is documented to list the issue events of a
repository, but requested /repos/{owner}/{repo}/issues/{id}/comments,
the comments of one issue. Request /repos/{owner}/{repo}/issues/events
and deprecate the $issueId parameter, which that endpoint has no use for.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant