Repository navigation
Conversation
GitHub returns just the SHA of a commit reference when the request asks for the application/vnd.github.sha media type. getSha() sent no Accept header, so it returned the JSON of the whole commit as a string. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Repositories\Commits::getSha($user, $repo, $ref)is documented to return the SHA-1 of a commit reference, but GitHub only answers with the bare SHA when the request sendsAccept: application/vnd.github.sha. Without it, the method returned the whole commit as a JSON string. It now passes that header with the request. A header passed with the request takes precedence over the defaultAcceptthat #65 adds.Testing Instructions
CommitsTest::testgetShaasserts theAcceptheader and the returned SHA; it fails before the change.Documentation Changes Required
docs/overview.md: short section ongetSha().🤖 Generated with Claude Code