Repository navigation
Conversation
The cookie-store key was a literal in http.clj, so it is public in git history. It now comes from :http/session-cookie-key in the server's config.edn, passed to Ring as bytes (the non-deprecated form). Without it, Ring uses a random key, so sessions reset on restart but the app runs. cloud_init.sh starts the JVM with -XX:-UseBASE64Intrinsics, an interim mitigation for CVE-2026-114938 until the JDK is 17.0.21.1 or later. Ring's cookie store Base64-decodes every session cookie before checking its HMAC, so the session cookie reaches the affected decoder.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
http.cljreads the cookie-store key from:http/session-cookie-key, set in the server's/home/compass/config.ednlike the other secrets, instead of a literal in source. It's passed to Ring as bytes, the non-deprecated form. If unset, Ring picks a random key: sessions reset on restart, but the app keeps working.ops/cloud_init.shstarts the JVM with-J-XX:-UseBASE64Intrinsics, an interim mitigation for CVE-2026-114938 (OpenJDK advisory). Remove it once the JDK is 17.0.21.1 or later.prod.edn, and CHANGELOG entries.Server steps (not covered by this PR)
:http/session-cookie-key(16 characters) in/home/compass/config.edn.cloud_init.shonly applies to new machines, so add-J-XX:-UseBASE64Intrinsicsto/etc/systemd/system/compass.service, then runsystemctl daemon-reloadand restart.Not done
I didn't run
bin/kaocha: it needs the local services. The edited files parse, and the Ring 1.15.5 source confirms the key handling.