Skip to content

Fix feature byte round trips in bindings - #1254

Open
tankyleo wants to merge 1 commit into
lightningdevkit:mainfrom
tankyleo:2026-11-fix-feature-byte-roundtrips
Open

tankyleo wants to merge 1 commit into
lightningdevkit:mainfrom
tankyleo:2026-11-fix-feature-byte-roundtrips

Conversation

@tankyleo

Copy link
Copy Markdown
Contributor
    Fix feature byte round trips in bindings

    Bindings callers need to preserve the advertised capabilities when
    storing or exchanging feature flags. Round-tripping through the byte
    helpers currently introduces extra feature bits, so reconstructed
    feature sets can report capabilities that were never advertised.

    Co-Authored-By: Codex

Bindings callers need to preserve the advertised capabilities when
storing or exchanging feature flags. Round-tripping through the byte
helpers currently introduces extra feature bits, so reconstructed
feature sets can report capabilities that were never advertised.

Co-Authored-By: Codex
@ldk-reviews-bot

ldk-reviews-bot commented Nov 21, 2026 •

Copy link
Copy Markdown

👋 Thanks for assigning @tnull as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@tankyleo
tankyleo requested a review from tnull November 21, 2026 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants