Skip to content

Memory tester adjustments - #315

Open
alan-george-lk wants to merge 4 commits into
mainfrom
alan/feature-memory-limits
Open

alan-george-lk wants to merge 4 commits into
mainfrom
alan/feature-memory-limits

Conversation

@alan-george-lk

Copy link
Copy Markdown
Collaborator
  • Adjusts failing threshold to 10 threads
  • Comments on PR when test fails

devin-ai-integration[bot]

This comment was marked as resolved.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 new potential issue.

Devin Review

Comment on lines +7 to +8
run_capture_bundle_tests:
description: Check selective and all-sources capture bundles outside PR runs.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Nightly tests blocked by renamed input

Scheduled and manual nightly runs fail validation because extended_capture_sources no longer exists. The nightly caller still passes it instead of run_capture_bundle_tests, preventing all nightly tests from starting.

Learn more

Reusable workflow callers can only pass inputs declared by the called workflow. The nightly caller still passes extended_capture_sources: true, but the declared input is now run_capture_bundle_tests. GitHub rejects this caller before its test jobs start.

Example: The daily scheduled nightly run invokes the test workflow with extended_capture_sources: true. Validation rejects that undeclared input instead of starting the test matrix.

Recommended fix: Rename the nightly caller's argument to run_capture_bundle_tests: true. Keep its value enabled so both scheduled and manual nightly runs execute the selective and all-sources bundle checks.

Devin Review


Was this helpful? React with 👍 or 👎 to provide feedback.

@alan-george-lk

alan-george-lk commented Nov 19, 2026 •

Copy link
Copy Markdown
Collaborator Author

✅ Memory checks passed.

CI run · Commit ab8938f

Memory tester results

Iterations: 100
Warmup: 20
Blocking limits: RSS growth ≤ 24 MiB; thread growth ≤ 10.
Advisory limits: RSS growth ≤ 8 MiB; thread growth ≤ 0.

Scenario RSS 0→20 RSS 20→100 Threads 0→20 Threads 20→100 Status
audio-track +17.17 MiB +0.10 MiB +7 0 ✅ PASS
video-track +18.03 MiB -0.08 MiB +7 0 ✅ PASS
data-track +12.94 MiB +0.13 MiB +1 0 ✅ PASS
room-reuse +12.77 MiB +0.03 MiB +1 0 ✅ PASS
room-client-leave +12.92 MiB -0.01 MiB +1 0 ✅ PASS
room-server-delete +15.20 MiB 0.00 MiB +1 0 ✅ PASS
capture-clock +118.68 MiB +0.73 MiB +7 0 ✅ PASS
capture-pattern +112.59 MiB +2.50 MiB +7 0 ✅ PASS
capture-gstreamer +35.69 MiB +0.53 MiB +9 0 ✅ PASS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant