Repository navigation
Add GStreamer audio capture and manual tester - #319
Draft
alan-george-lk wants to merge 4 commits into
Draft
alan-george-lk wants to merge 4 commits into
alan-george-lk wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add GStreamer PCM audio capture to the C++ capture API, backed by the Rust implementation in livekit/rust-sdks#1702. Pin the Rust submodule to
1387ff328cc9eaf579e6b4aa99c8111f8a3e695a.Split the public capture API into audio, video, and shared-type headers while preserving
capture_source.has the compatibility umbrella. Audio uses fixed 10 ms frames, and terminal capture results report accepted frames and the exit reason for both media types.Add a macOS
capture_audiomanual tester to capture-enabled test builds. It supports the default microphone, custom GStreamer pipelines, optional room publication, and bounded or Ctrl+C shutdown. Update documentation and add stereo buffer rechunking coverage.Validation on macOS arm64:
cargo check../build.sh release-tests --capture=allpassed using the locally rebuilt, unstripped Rust FFI library to avoid the existing Apple linker LINKEDIT issue.LIVEKIT_CREATE_TOKEN_URLis unset.Known follow-ups: finite audio capture rejects a final partial 10 ms frame; direct WAV encoding in a capture pipeline may not finalize its header during teardown. Recording PCM and converting afterward works with the current tester. Other platforms have not been exercised locally.