Skip to content

STF-2455: Release 1.7.0 and 1.7.1 - #299

Merged
ugexe merged 8 commits into
mainfrom
greg/release-1.7.0
Nov 18, 2026
Merged

ugexe merged 8 commits into
mainfrom
greg/release-1.7.0

Conversation

@oschwald

@oschwald oschwald commented Nov 17, 2026 •

Copy link
Copy Markdown
Member

Releases 1.7.0 and 1.7.1. 1.7.0 is already on RubyGems.org. 1.7.1 republishes it with a Sigstore attestation.

1.7.0 (released). The only user-facing change is the higher maxmind-db floor, ~> 1.5. maxmind-db 1.5.0 also makes lookups faster, so 1.7.0 is a minor release. The commits:

  • Require maxmind-db 1.5.0. maxmind-db 1.5.0 limits the work and memory of each decode, rejects pointers to pointers, and speeds up lookups. The changelog gives the default limits and warns that opening or looking up a custom database can now raise MaxMind::DB::InvalidDatabaseError. Gemfile.lock already resolved 1.5.0, so only its dependency line changes.
  • Set the release date and Update for v1.7.0, which release.sh added.

The 1.7.0 release workflow pushed the gem without an attestation, and then failed. The workflow's bundle install put json 3.1.0, a RuboCop dependency in Gemfile.lock, into the system gems. rubygems/release-gem signs the gem by running its pinned sigstore-cli 0.2.3 in an unbundled environment. That process loaded json 3.1.0 and failed: unknown keywords: allow_blank, create_additions, allow_infinity. The wait step then failed too, because rubygems-await breaks on Ruby 4.0. RubyGems.org accepts an attestation only when a gem is pushed, so 1.7.0 cannot get one now.

1.7.1 (not released yet). This is a patch release, because the gem's code does not change. The commits:

  • Keep the release bundle out of the system gems. The job sets BUNDLE_PATH: vendor/bundle. bundle exec rake release still finds the bundle, and the unbundled sigstore process sees only Ruby's own json. Ruby 4.0's built-in json is 2.18.0. I tested this locally on Ruby 4.0.6 with an empty system gem directory: a frozen bundle install into vendor/bundle, then the same unbundled gem exec sigstore-cli:0.2.3 sign call that the action makes. sigstore got past the json parse and stopped only because no OIDC identity token exists locally. vendor/bundle is in .gitignore, and the gemspec packs only git ls-files.
  • Update rubygems/release-gem to v1.4.2. v1.4.2 waits for the release without rubygems-await, whose 0.5.4 version raised undefined method 'dependencies' for Gem::CompactIndexClient::Cache until the 1.7.0 job failed.
  • Fail the release job when the gem has no attestation. release-gem catches a signing error, pushes the gem unsigned, and still passes, which is how 1.7.0 shipped. A new step asks the RubyGems.org attestation API about each pushed gem and fails the job if the list is empty. It passes for 1.6.0 and fails for 1.7.0. zizmor reports no findings.
  • Add the 1.7.1 changelog entry, with the release date. If the release happens on a later day, the date needs another commit first.

The same failure can affect minfraud-api-ruby and MaxMind-DB-Reader-ruby, which still use release-gem v1.4.1 with no BUNDLE_PATH. minfraud-api-ruby's release PR in this round will get the same changes.

mise.lock does not change. mise 2026.11.9 refuses to lock Ruby 4.0.9, because its linux-arm64-musl entry would lose the GitHub attestation that the current Ruby 4.0.6 entry records.

Part of STF-2455.

🤖 Generated with Claude Code

Copilot AI balanced review requested due to automatic review settings November 17, 2026 22:54

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

@coderabbitai

coderabbitai Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Explain Change →

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 14 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 98b37762-c2e8-4dd2-9af0-2cbba806df61
Commits

Reviewing files that changed from the base of the PR and between 0420b07 and 3fdef42.

Files ignored due to path filters: 1

  • Gemfile.lock is excluded by !**/*.lock
Files selected for processing: 4

  • .github/workflows/release.yml
  • CHANGELOG.md
  • lib/maxmind/geoip2/version.rb
  • maxmind-geoip2.gemspec

No actionable comments were generated in the recent review.

Walkthrough

The gemspec now requires maxmind-db ~> 1.5. The changelog adds a 1.7.0 entry dated 2026-11-17, describing the dependency version and its stated decoder and lookup changes.

Changes: maxmind-db dependency update

Layer / File(s) Summary
Dependency requirement and release notes
maxmind-geoip2.gemspec, CHANGELOG.md
The runtime dependency constraint changes from ~> 1.4 to ~> 1.5. The changelog adds a 1.7.0 entry describing the minimum version and its stated decoder limits, pointer rejection, and lookup speed.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Merge Risk: Minimal · previous review 0420b

This release raises the minimum maxmind-db version to 1.5 and adds release notes. The lockfile already uses that version, so the risk of merging is minimal.

Pre-merge checks: Passed 4

Check name Status Explanation
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Title check Passed The title names a release (1.7.0 and 1.7.1) and a ticket ID, but the changeset only adds a 1.7.0 changelog entry and raises the maxmind-db dependency floor from ~> 1.4 to ~> 1.5. The title does not me…
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Full details: Title check

Explanation

The title names a release (1.7.0 and 1.7.1) and a ticket ID, but the changeset only adds a 1.7.0 changelog entry and raises the maxmind-db dependency floor from ~> 1.4 to ~> 1.5. The title does not mention the dependency change, which is the main user-facing change. It also refers to 1.7.1, which the changelog entry does not document, so the title is partially related to the changeset.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

A rabbit checks the version line,
Then nibbles notes on what is new.
“One point five,” it says with cheer,
And hops through changelog pages here.
The release is marked; the burrow’s clear.

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 81e6b1ad-b532-49f3-a810-20554953eb53
Commits

Reviewing files that changed from the base of the PR and between 56ba1e9 and 0420b07.

Files ignored due to path filters: 1

  • Gemfile.lock is excluded by !**/*.lock
Files selected for processing: 2

  • CHANGELOG.md
  • maxmind-geoip2.gemspec

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

oschwald and others added 2 commits November 17, 2026 23:00
maxmind-db 1.5.0 limits the resources a crafted database can make the
decoder use, rejects pointers to pointers, and speeds up lookups.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings November 17, 2026 23:00

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

Copilot AI balanced review requested due to automatic review settings November 17, 2026 23:11

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

@oschwald oschwald changed the title STF-2455: Release 1.7.0 STF-2455: Release 1.7.0 and 1.7.1 Nov 17, 2026
Copilot AI balanced review requested due to automatic review settings November 17, 2026 23:27

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

Copilot AI balanced review requested due to automatic review settings November 17, 2026 23:30

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

oschwald and others added 4 commits November 17, 2026 23:32
rubygems/release-gem signs the gem by running sigstore-cli 0.2.3 with
Bundler.unbundled_env. The bundle install step had put json 3.1.0,
a RuboCop dependency in Gemfile.lock, into the system gems, so sigstore
loaded it and failed: "unknown keywords: allow_blank, create_additions,
allow_infinity". The action then pushed 1.7.0 without an attestation.

With BUNDLE_PATH set for the job, bundle exec still finds the bundle,
and the unbundled sigstore sees only Ruby's default json.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The v1.4.1 "Wait for release to propagate" step runs rubygems-await,
which fails on Ruby 4.0 with "undefined method 'dependencies' for
Gem::CompactIndexClient::Cache". It retried until the 1.7.0 job timed
out. v1.4.2 waits for the release without rubygems-await.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
release-gem catches a signing error, pushes the gem without an
attestation, and the job still passes. That is how 1.7.0 shipped
unsigned. Ask RubyGems.org for the attestation after the push.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings November 17, 2026 23:33

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

Copilot AI balanced review requested due to automatic review settings November 17, 2026 23:40

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

@ugexe
ugexe merged commit 269c161 into main Nov 18, 2026
55 checks passed
@ugexe
ugexe deleted the greg/release-1.7.0 branch November 18, 2026 19:29

This branch was successfully deployed

1 active deployment
release — 3fdef425 Deployed Nov 17, 2026 by oschwald via push #525
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants