Repository navigation
Temporarily exclude Embedding from NuGet.org releases - #519
Merged
Vladimir Morozov (vmoroz) merged 2 commits intoNov 18, 2026
Merged
Vladimir Morozov (vmoroz) merged 2 commits into
Vladimir Morozov (vmoroz) merged 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for the temporary exclusion of Embedding packages from NuGet.org releases.
No open issues 🎉
What changed in this PR
Temporarily excludes the Embedding package from NuGet.org releases to unblock publishing while ESRP registration is pending. Package builds and Azure DevOps feed publishing remain unchanged.
Changes:
- Removes Embedding packages from the ESRP submission folder by default.
- Adds
publishEmbeddingPackage, defaulting tofalse, to allow registration testing. - Documents the temporary exclusion and how to enable publishing.
| File | Description |
|---|---|
docs/reference/packages-releases.md |
Documents the exclusion and registration-testing option. |
.ado/release.yml |
Adds the parameter and conditional removal from ESRP submissions. |
Review effort: Balanced
Nikolai Aristov (NikoAri)
approved these changes
Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
ESRP currently rejects
Microsoft.JavaScript.NodeApi.Embedding, blocking NuGet.org releases while its registration is pending.What
publishEmbeddingPackage, defaulting tofalse; enable it to skip the removal task and test ESRP registration.Testing
Both settings passed Azure DevOps YAML previews; PowerShell fixture checks and
git diff --checkpassed.