Skip to content

Temporarily exclude Embedding from NuGet.org releases - #519

Merged
Vladimir Morozov (vmoroz) merged 2 commits into
microsoft:mainfrom
vmoroz:PR/disable-embedding-publish
Nov 18, 2026
Merged

Vladimir Morozov (vmoroz) merged 2 commits into
microsoft:mainfrom
vmoroz:PR/disable-embedding-publish

Conversation

@vmoroz

Copy link
Copy Markdown
Member

Why

ESRP currently rejects Microsoft.JavaScript.NodeApi.Embedding, blocking NuGet.org releases while its registration is pending.

What

  • Temporary exclusion: Remove Embedding packages from the ESRP submission folder without changing package builds or Azure DevOps feed publishing.
  • Registration testing: Add publishEmbeddingPackage, defaulting to false; enable it to skip the removal task and test ESRP registration.

Testing

Both settings passed Azure DevOps YAML previews; PowerShell fixture checks and git diff --check passed.

Copilot AI balanced review requested due to automatic review settings November 18, 2026 21:46

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are recorded for the temporary exclusion of Embedding packages from NuGet.org releases.

No open issues 🎉

What changed in this PR

Temporarily excludes the Embedding package from NuGet.org releases to unblock publishing while ESRP registration is pending. Package builds and Azure DevOps feed publishing remain unchanged.

Changes:

  • Removes Embedding packages from the ESRP submission folder by default.
  • Adds publishEmbeddingPackage, defaulting to false, to allow registration testing.
  • Documents the temporary exclusion and how to enable publishing.
File Description
docs/​reference/​packages-releases.md Documents the exclusion and registration-testing option.
.ado/​release.yml Adds the parameter and conditional removal from ESRP submissions.

Review effort: Balanced

Copilot AI balanced review requested due to automatic review settings November 18, 2026 21:57

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the temporary exclusion of Embedding packages from NuGet.org releases.

No open issues 🎉

Review effort: Balanced

@vmoroz
Vladimir Morozov (vmoroz) merged commit bf0caa4 into microsoft:main Nov 18, 2026
17 checks passed
@vmoroz
Vladimir Morozov (vmoroz) deleted the PR/disable-embedding-publish branch November 18, 2026 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants