Repository navigation
Update LibNode to 26.1.2 and publish releases only for main CI runs - #520
Merged
Vladimir Morozov (vmoroz) merged 3 commits intoNov 19, 2026
Merged
Conversation
The Release pipeline now evaluates the CI run it consumes, as v8-jsi does: it publishes only when that run built refs/heads/main, and otherwise renames the run "Skipped - ..." and skips publishing. The Release pipeline's own branch is not a condition. CI no longer uploads symbols. It stages the same PDBs as a published-symbols pipeline artifact, and the gated Release stage lists and publishes them with PublishSymbols@2.
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the LibNode update and release-publishing changes.
No open issues 🎉
What changed in this PR
Updates LibNode to 26.1.2 to propagate linked-module initialization errors, supporting the stronger tests in #512. Moves symbol publishing into Release and limits publishing to artifacts from main CI runs.
Changes:
- Bump the central LibNode version from 26.0.18 to 26.1.2.
- Gate Release publishing on the consumed CI run’s branch, regardless of the Release run’s branch.
- Stage PDBs as a CI artifact and publish them only from the gated Release stage.
| File | Description |
|---|---|
| Directory.Packages.props | Updates the central LibNode dependency pin. |
| .ado/release.yml | Adds the CI-branch gate and symbol-publishing job. |
| .ado/publish.yml | Replaces direct symbol publishing with a published-symbols artifact. |
Review effort: Balanced
Nikolai Aristov (NikoAri)
approved these changes
Nov 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
LibNode 26.1.2 fixes a bug where an error thrown by a linked module's initializer never reached the caller of
process._linkedBinding()(microsoft/v8-jsi#289). It unblocks the stronger tests in #512.The Release pipeline also published whatever CI run it consumed, and CI uploaded symbols from every branch. Like v8-jsi, Release now publishes only CI runs from
main, so a test branch can run CI and Release without publishing anything.What
refs/heads/mainCI run reaches the publishing stage; otherwise the run is renamedSkipped - ...and nothing is published. The Release run's own branch isn't checked, so a Release from another branch can still publish an existingmainCI build, for example after a Release-only fix.published-symbolspipeline artifact, and a new job in the gated stage lists and publishes them..snupkgpackages don't change. Re-releasing amainCI run built before this change fails only that job, since the run has nopublished-symbolsartifact.Testing
Local Windows x64 build and tests on net472, net8.0, net9.0, and net10.0 with LibNode 26.1.2. Azure DevOps YAML previews of both pipelines; the gate script was checked with
main, other, empty, and unresolved CI branches.Changelog
Should this change be included in the release notes: yes
Update LibNode to 26.1.2, which reports errors thrown by linked module initializers.