Skip to content

Update LibNode to 26.1.2 and publish releases only for main CI runs - #520

Merged
Vladimir Morozov (vmoroz) merged 3 commits into
microsoft:mainfrom
vmoroz:PR/libnode-26-1-2
Nov 19, 2026
Merged

Vladimir Morozov (vmoroz) merged 3 commits into
microsoft:mainfrom
vmoroz:PR/libnode-26-1-2

Conversation

@vmoroz

Copy link
Copy Markdown
Member

Why

LibNode 26.1.2 fixes a bug where an error thrown by a linked module's initializer never reached the caller of process._linkedBinding() (microsoft/v8-jsi#289). It unblocks the stronger tests in #512.

The Release pipeline also published whatever CI run it consumed, and CI uploaded symbols from every branch. Like v8-jsi, Release now publishes only CI runs from main, so a test branch can run CI and Release without publishing anything.

What

  • LibNode 26.1.2. Bump the central pin from 26.0.18. The embedding API is unchanged.
  • Release gate. A new first stage checks the branch of the CI run that Release consumes. Only a refs/heads/main CI run reaches the publishing stage; otherwise the run is renamed Skipped - ... and nothing is published. The Release run's own branch isn't checked, so a Release from another branch can still publish an existing main CI build, for example after a Release-only fix.
  • Symbols from Release only. CI no longer uploads PDBs to the symbol server. It saves the same PDBs in a published-symbols pipeline artifact, and a new job in the gated stage lists and publishes them. .snupkg packages don't change. Re-releasing a main CI run built before this change fails only that job, since the run has no published-symbols artifact.

Testing

Local Windows x64 build and tests on net472, net8.0, net9.0, and net10.0 with LibNode 26.1.2. Azure DevOps YAML previews of both pipelines; the gate script was checked with main, other, empty, and unresolved CI branches.

Changelog

Should this change be included in the release notes: yes

Update LibNode to 26.1.2, which reports errors thrown by linked module initializers.

The Release pipeline now evaluates the CI run it consumes, as v8-jsi
does: it publishes only when that run built refs/heads/main, and
otherwise renames the run "Skipped - ..." and skips publishing. The
Release pipeline's own branch is not a condition.

CI no longer uploads symbols. It stages the same PDBs as a
published-symbols pipeline artifact, and the gated Release stage lists
and publishes them with PublishSymbols@2.
Copilot AI balanced review requested due to automatic review settings November 19, 2026 00:32

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the LibNode update and release-publishing changes.

No open issues 🎉

What changed in this PR

Updates LibNode to 26.1.2 to propagate linked-module initialization errors, supporting the stronger tests in #512. Moves symbol publishing into Release and limits publishing to artifacts from main CI runs.

Changes:

  • Bump the central LibNode version from 26.0.18 to 26.1.2.
  • Gate Release publishing on the consumed CI run’s branch, regardless of the Release run’s branch.
  • Stage PDBs as a CI artifact and publish them only from the gated Release stage.
File Description
Directory.Packages.props Updates the central LibNode dependency pin.
.ado/​release.yml Adds the CI-branch gate and symbol-publishing job.
.ado/​publish.yml Replaces direct symbol publishing with a published-symbols artifact.

Review effort: Balanced

@vmoroz
Vladimir Morozov (vmoroz) merged commit 3c72a8b into microsoft:main Nov 19, 2026
17 checks passed
@vmoroz
Vladimir Morozov (vmoroz) deleted the PR/libnode-26-1-2 branch November 19, 2026 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants