Repository navigation
Add stopAllThreadsOnSuspend and steppingResumesAllThreads to launch.json schema - #1145
Open
TEJA P C (PCTEJA) wants to merge 1 commit into
Open
TEJA P C (PCTEJA) wants to merge 1 commit into
TEJA P C (PCTEJA) wants to merge 1 commit into
Conversation
…son schema Both options are honoured by debugpy (read in _set_debug_options for launch and attach sessions, each defaulting to true) but were missing from the debugpy launch/attach configuration schema, so VS Code flagged them as unknown properties in launch.json. Add both boolean options (default true) with documentation to the launch and attach schemas in package.json, and declare them on ICommonDebugArguments so they are typed for both request types. Fixes microsoft#1133
Author
@microsoft-github-policy-service agree |
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1133.
stopAllThreadsOnSuspendandsteppingResumesAllThreadsare honoured by debugpy but were missing from this extension's launch.json schema, so VS Code reported them as unknown properties.Support in debugpy: both options are read in
_set_debug_optionsin pydevd's JSON command handler for launch and attach sessions (steppingResumesAllThreadsviaargs.get("steppingResumesAllThreads", True);stopAllThreadsOnSuspendadded in microsoft/debugpy#2010), each defaulting totrue`. The extension's launch/attach resolvers pass configuration through to the debug adapter unfiltered, so declaring the options in the schema and types is sufficient for them to be documented and validated.Changes
package.json: addsteppingResumesAllThreadsandstopAllThreadsOnSuspend(boolean,default: true, with descriptions documenting the behaviour and defaults) to both thelaunchandattachconfigurationAttributesschemas.src/extension/types.ts: declare both options onICommonDebugArguments, which is shared by the launch and attach argument types.No other files need changes: comparable debugpy-consumed options follow the same schema-and-types pattern (for example `breakOnSystemExit), and resolver changes are not required for passthrough options.
Testing
package.jsonparses as valid JSON; both properties present in both schemas withdefault: true.npm run compile-tests(tsc) passes.eslintandprettier --checkpass onsrc/extension/types.ts.Note: the full VS Code test-host suite was not run locally (it requires downloading a VS Code build); CI will exercise it.
I have reviewed every changed line and take responsibility for it.