Repository navigation
fix: treat paths with https:// only in the query as relative - #2040
Open
alexcastgonz (pcbeingused333) wants to merge 1 commit into
Open
alexcastgonz (pcbeingused333) wants to merge 1 commit into
alexcastgonz (pcbeingused333) wants to merge 1 commit into
Conversation
parsePath checked for https:// anywhere in the path, so relative paths such as /sites?search=https://contoso.sharepoint.com were parsed as absolute URLs and rejected. Only treat the path as absolute when it starts with https://.
alexcastgonz (pcbeingused333)
requested a review
from a team
as a code owner
November 16, 2026 11:08
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2039
Cause.
GraphRequest.parsePathdecided a path was an absolute URL withpath.indexOf("https://") !== -1, so any relative path that merely containshttps://(for example in a query value) went down the absolute-URL branch, failednew URL(path)and threwGraphClientError: Unable to parse the URL. Examples:client.api("/sites?search=https://contoso.sharepoint.com"),/me/drive/root/search(q='https://example').Fix. Only take the absolute-URL branch when the path starts with
https://. The userinfo rejection and host/version extraction are unchanged.Tests. Added cases to
test/common/core/urlParsing.tsfor relative paths with an embeddedhttps://; they fail before the change and pass after. The rest oftest/common/corestill passes (113 passing).Reproduction
client.api("/sites?search=https://contoso.sharepoint.com")throws before any HTTP request; expected URLhttps://graph.microsoft.com/v1.0/sites?search=https://contoso.sharepoint.com.This change was prepared with the help of an AI coding assistant (Claude) and submitted by the account owner.