Repository navigation
Conversation
…e capability Elicitation is an optional client capability in 2025-11-25. The scenario previously sent elicitation/create unconditionally, so a client that legitimately declined to declare elicitation failed all six checks with -32601. Read capabilities from initialize: when elicitation is absent the tool returns without eliciting and every check reports SKIPPED; a client that does declare it is still scored (and still fails if it rejects). This fixes modelcontextprotocol#584
commit: |
At 2025-11-25 elicitation splits into form and url modes, so a client
declaring only {elicitation: {url: {}}} must not receive the scenario's
form elicitation/create request; a bare {elicitation: {}} stays
backwards-compatible with form. Read the settled capabilities from the
SDK server per session instead of intercepting initialize.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Elicitation is an optional client capability in 2025-11-25, split into
formandurlmodes, but theelicitation-sep1034-client-defaultsscenario sent its formelicitation/createunconditionally. A client that legitimately negotiates without form-mode elicitation answered-32601and failed all six checks, so it could never report a clean baseline.The mock server now reads the settled client capabilities per session via
Server.getClientCapabilities(). When the client did not declare form support — noelicitationcapability, or a URL-only{elicitation: {url: {}}}declaration —tools/callreturns without eliciting and every check reportsSKIPPED, the status the check conventions reserve for an optional capability the implementation never declared. A bare{elicitation: {}}is backwards-compatible with form and a client declaring{elicitation: {form: {}}}is scored normally — and still fails if it rejects the request (verified by negative tests).Fixes #584
Verification
src/scenarios/client/elicitation-defaults.test.tsdrives the scenario in-process:capabilities: {}→ all 6 checksSKIPPED, noFAILUREelicitation: {url: {}}(URL-only) → all 6 checksSKIPPED, noFAILUREelicitation: {}orelicitation: {form: {}}but no handler →client-elicitation-sep1034-generalFAILUREwithElicitation failed, nothingSKIPPEDnpm run typecheck,eslint,prettierclean; full suite 645 tests pass.