Skip to content

fix(client): skip elicitation-sep1034-defaults for clients without the capability - #593

Open
jstar0 wants to merge 2 commits into
modelcontextprotocol:mainfrom
jstar0:fix/elicitation-capability-gating
Open

jstar0 wants to merge 2 commits into
modelcontextprotocol:mainfrom
jstar0:fix/elicitation-capability-gating

Conversation

@jstar0

@jstar0 jstar0 commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Elicitation is an optional client capability in 2025-11-25, split into form and url modes, but the elicitation-sep1034-client-defaults scenario sent its form elicitation/create unconditionally. A client that legitimately negotiates without form-mode elicitation answered -32601 and failed all six checks, so it could never report a clean baseline.

The mock server now reads the settled client capabilities per session via Server.getClientCapabilities(). When the client did not declare form support — no elicitation capability, or a URL-only {elicitation: {url: {}}} declaration — tools/call returns without eliciting and every check reports SKIPPED, the status the check conventions reserve for an optional capability the implementation never declared. A bare {elicitation: {}} is backwards-compatible with form and a client declaring {elicitation: {form: {}}} is scored normally — and still fails if it rejects the request (verified by negative tests).

Fixes #584

Verification

  • src/scenarios/client/elicitation-defaults.test.ts drives the scenario in-process:
    • client with capabilities: {} → all 6 checks SKIPPED, no FAILURE
    • client with elicitation: {url: {}} (URL-only) → all 6 checks SKIPPED, no FAILURE
    • clients with elicitation: {} or elicitation: {form: {}} but no handler → client-elicitation-sep1034-general FAILURE with Elicitation failed, nothing SKIPPED
  • npm run typecheck, eslint, prettier clean; full suite 645 tests pass.

…e capability

Elicitation is an optional client capability in 2025-11-25. The scenario
previously sent elicitation/create unconditionally, so a client that
legitimately declined to declare elicitation failed all six checks with
-32601. Read capabilities from initialize: when elicitation is absent the
tool returns without eliciting and every check reports SKIPPED; a client
that does declare it is still scored (and still fails if it rejects).

This fixes modelcontextprotocol#584
@pkg-pr-new

pkg-pr-new Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

Open in StackBlitz

npx https://pkg.pr.new/@modelcontextprotocol/conformance@593

commit: 79bcb45

At 2025-11-25 elicitation splits into form and url modes, so a client
declaring only {elicitation: {url: {}}} must not receive the scenario's
form elicitation/create request; a bare {elicitation: {}} stays
backwards-compatible with form. Read the settled capabilities from the
SDK server per session instead of intercepting initialize.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Client scenario elicitation-sep1034-client-defaults (2025-11-25) elicits a client that did not declare the elicitation capability

1 participant