Skip to content

fix(server): route Streamable HTTP POSTs with modern _meta envelope to modern handler - #3873

Closed
DevKursat wants to merge 1 commit into
modelcontextprotocol:mainfrom
DevKursat:fix/streamable-http-modern-envelope-routing
Closed

DevKursat wants to merge 1 commit into
modelcontextprotocol:mainfrom
DevKursat:fix/streamable-http-modern-envelope-routing

Conversation

@DevKursat

Copy link
Copy Markdown

Fixes #3863

Summary

  • Shared has_modern_envelope() in mcp.shared.inbound (reused by both mcp.server.runner and StreamableHTTPSessionManager).
  • In StreamableHTTPSessionManager._handle_request(), when a POST request carries a 2025-era or missing MCP-Protocol-Version header, inspect the buffered body once (with an ASGI replay wrapper) and route non-initialize requests carrying params._meta['io.modelcontextprotocol/protocolVersion'] to handle_modern_request(), where classify_inbound_request rejects the mismatch with 400 / -32020 (HEADER_MISMATCH).
  • Unparseable/legacy bodies continue onto the existing legacy path unchanged.

Verification

  • Added parameterized regression test test_modern_envelope_routes_to_modern_handler_regardless_of_header in tests/server/test_streamable_http_manager.py (covering both 2025-11-25 and missing headers).
  • uv run pyright: 0 errors, 0 warnings.
  • uv run ruff check: all checks passed.
  • uv run pytest tests/server/test_streamable_http_manager.py tests/server/test_streamable_http_modern.py: 124 passed.

@github-actions github-actions Bot added the missing-issue-link Auto-closed: PR needs a linked issue assigned to its author (see CONTRIBUTING.md) label Nov 18, 2026
@github-actions

Copy link
Copy Markdown
Contributor

This PR has been closed automatically. This repo only keeps pull requests open when they come from a maintainer, or from a contributor a maintainer has assigned to the linked issue, and you aren't currently assigned to #3863.

If a maintainer assigns you to #3863, this PR reopens on its own and there's nothing more you need to do here. Assignment is a maintainer call based on capacity; comments that only ask to be assigned don't factor in. What does help is engaging on the issue itself by confirming the repro, explaining why it matters for your use case, or describing the approach you'd take.

You're welcome to keep pushing commits here (just avoid force-pushing, since GitHub can't reopen a rewritten branch), but that on its own won't get the PR reviewed or the issue assigned, and realistically most auto-closed PRs stay closed. There's no need to open a new PR either way.

CONTRIBUTING.md has the full reasoning, but in short:

  • We're a small team with very little capacity to review community PRs right now.
  • Many recent PRs are AI-generated with little human review, and reviewing one carefully still costs a maintainer as much time as it ever did. A well-described issue is usually more useful to us than the code.

Maintainers: reopen, remove missing-issue-link, or add bypass-issue-check to override.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

missing-issue-link Auto-closed: PR needs a linked issue assigned to its author (see CONTRIBUTING.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Streamable HTTP serves a 2026-07-28 request as legacy when the MCP-Protocol-Version header is 2025-era or missing

1 participant