Skip to content

docs(examples): add skills server and client examples - #1466

Open
DaleSeo wants to merge 3 commits into
mainfrom
DaleSeo/skills-example
Open

DaleSeo wants to merge 3 commits into
mainfrom
DaleSeo/skills-example

Conversation

@DaleSeo

@DaleSeo DaleSeo commented Nov 16, 2026 •

Copy link
Copy Markdown
Member

Motivation and Context

skills-fs shipped in v3.10.0 with a wiring snippet in the module docs but no runnable example. This adds a stdio server that serves a skill folder and a client that walks the extension from the host side.

How Has This Been Tested?

Breaking Changes

None.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

@github-actions github-actions Bot added T-documentation Documentation improvements T-config Configuration file changes T-examples Example code changes labels Nov 16, 2026
@github-actions

Copy link
Copy Markdown
Contributor

@michaelneale is on triage rotation this week and is the reviewer for this one.

Labels come from the PR labeler. Please review the change.

Automated triage. Labels are a first pass and the assigned maintainer has the final say.

@DaleSeo
DaleSeo marked this pull request as ready for review November 16, 2026 20:06
@DaleSeo
DaleSeo requested a review from a team as a code owner November 16, 2026 20:06
@DaleSeo DaleSeo self-assigned this Nov 16, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-20T14:52:36.802954Z d52f224 New commits
🔒 Security Review ✅ Completed 2026-11-20T14:54:00.011229Z d52f224 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

tsarlandie-oai
tsarlandie-oai previously approved these changes Nov 20, 2026

@tsarlandie-oai tsarlandie-oai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - some minor comments.

Comment thread examples/clients/src/skills_stdio.rs Outdated
Implementation::from_build_env(),
);
let client = client_info
.serve(TokioChildProcess::new(Command::new("cargo").configure(

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.serve() negotiated 2025-11-25 with the bundled server. Could we use serve_with_lifecycle with ClientLifecycleMode::Discover preferring V_2026_07_28 so the requests carry the required _meta? Skills protocol revision · SDK example

Comment thread examples/clients/src/skills_stdio.rs Outdated
tracing::info!(uri = %skill.uri, "resources are dynamic; browse the directory instead");
continue;
};
for file in files {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The extension prohibits prefetching files on listing. Could we select pdf-processing, load its SKILL.md, browse templates/, then read just the selected invoice using the held manifest? Lazy retrieval

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reworked the flow to match. It selects pdf-processing, loads only its SKILL.md, browses the templates/ folder, and then reads just invoice.md. It checks each file against the manifest it already has.

Comment thread examples/clients/src/skills_stdio.rs Outdated
}
_ => return Err(anyhow!("{} came back without contents", file.uri)),
};
file.verify(&bytes)?;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

file.verify() checks size and digest. For SKILL.md, could we also parse the YAML frontmatter and compare it field by field with manifest.frontmatter before treating the skill as verified? Frontmatter verification

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c526146276

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread examples/clients/src/skills_stdio.rs Resolved

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T-config Configuration file changes T-documentation Documentation improvements T-examples Example code changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants