Repository navigation
Conversation
|
@michaelneale is on triage rotation this week and is the reviewer for this one. Labels come from the PR labeler. Please review the change. Automated triage. Labels are a first pass and the assigned maintainer has the final say. |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
tsarlandie-oai
left a comment
There was a problem hiding this comment.
Looks good - some minor comments.
| Implementation::from_build_env(), | ||
| ); | ||
| let client = client_info | ||
| .serve(TokioChildProcess::new(Command::new("cargo").configure( |
There was a problem hiding this comment.
.serve() negotiated 2025-11-25 with the bundled server. Could we use serve_with_lifecycle with ClientLifecycleMode::Discover preferring V_2026_07_28 so the requests carry the required _meta? Skills protocol revision · SDK example
| tracing::info!(uri = %skill.uri, "resources are dynamic; browse the directory instead"); | ||
| continue; | ||
| }; | ||
| for file in files { |
There was a problem hiding this comment.
The extension prohibits prefetching files on listing. Could we select pdf-processing, load its SKILL.md, browse templates/, then read just the selected invoice using the held manifest? Lazy retrieval
There was a problem hiding this comment.
I reworked the flow to match. It selects pdf-processing, loads only its SKILL.md, browses the templates/ folder, and then reads just invoice.md. It checks each file against the manifest it already has.
| } | ||
| _ => return Err(anyhow!("{} came back without contents", file.uri)), | ||
| }; | ||
| file.verify(&bytes)?; |
There was a problem hiding this comment.
file.verify() checks size and digest. For SKILL.md, could we also parse the YAML frontmatter and compare it field by field with manifest.frontmatter before treating the skill as verified? Frontmatter verification
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c526146276
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Motivation and Context
skills-fsshipped in v3.10.0 with a wiring snippet in the module docs but no runnable example. This adds a stdio server that serves a skill folder and a client that walks the extension from the host side.How Has This Been Tested?
Breaking Changes
None.
Types of changes
Checklist