Repository navigation
Conversation
|
@michaelneale is on triage rotation this week and is the reviewer for this one. Labels come from the PR labeler. Please review the change. Automated triage. Labels are a first pass and the assigned maintainer has the final say. |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
| return false; | ||
| } | ||
|
|
||
| if Self::is_same_origin(base_url, url) { |
There was a problem hiding this comment.
If the resource uses HTTP, a same-origin private issuer also passes this check over HTTP. Could we require HTTPS for the new non-loopback issuer exception and add a same-origin HTTP rejection case? MCP communication security
| #[case::cgnat("https://100.64.0.1", "https://100.64.0.1", false, true)] | ||
| #[case::mapped_ipv4("https://[::ffff:a00:1]", "https://[::ffff:a00:1]", false, true)] | ||
| #[case::nat64("https://[64:ff9b::a00:1]", "https://[64:ff9b::a00:1]", false, true)] | ||
| #[case::link_local("https://[fe80::1]", "https://[fe80::1]", false, true)] |
There was a problem hiding this comment.
The constructor promises to reject link-local and reserved addresses. Could we limit the issuer exception to AddressClass::Private and keep Blocked rejected? If the configured literal is intentionally exempt, please document that exception. Constructor contract · MCP address guidance
There was a problem hiding this comment.
Good catch. The exception now only widens allow_private at the issuer check, so it allows AddressClass::Private while keeping Blocked rejected, as the constructor docs promise.
Motivation and Context
Following up on #1393, OAuth discovery now accepts an authorization server on the resource’s own origin, regardless of its IP address type.
How Has This Been Tested?
Added tests
Breaking Changes
None.
Types of changes
Checklist