Repository navigation
Conversation
|
@modelcontextprotocol/client
@modelcontextprotocol/codemod
@modelcontextprotocol/core
@modelcontextprotocol/server
@modelcontextprotocol/server-legacy
@modelcontextprotocol/express
@modelcontextprotocol/fastify
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
The SSE cells throw inside waitFor before the call promise is awaited, so a timeout rejection is left unhandled. Attach a handler the way protocol:timeout:max-total already does. Fixes modelcontextprotocol#3170
harmenx
force-pushed
the
fix/e2e-reset-on-progress-rejection
branch
from
November 20, 2026 07:06
41e3a9b to
2980e8d
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SSE cells of
protocol:timeout:reset-on-progressthrow insidevi.waitForbefore the call promise is awaited, so the request's timeout rejection is left unhandled. Attach a handler as soon as the promise is created, the wayprotocol:timeout:max-totalalready does.Fixes #3170
Motivation and Context
The SSE cells are known failures, but because nothing holds the call promise's rejection when they throw early, vitest on macOS exits 1 with an unhandled
SdkError: Request timed out, even though every assertion is an expected failure. This makes the e2e run fail for the wrong reason.How Has This Been Tested?
pnpm --filter @modelcontextprotocol/test-e2e exec vitest run scenarios/protocol.test.ts -t 'reset-on-progress': 10 passed, 2 expected fail. ESLint and Prettier are clean on the changed file. On Linux the unpatched run already exits 0; the unhandled rejection is what the issue records on macOS. The success path still awaitscalland asserts the result.Breaking Changes
None. Test-only change.
Types of changes
Checklist
Additional context
Only
test/e2e/scenarios/protocol.test.tschanges. The handler is attached before the progress loop, matchingprotocol:timeout:max-total.