Repository navigation
fix(server): complete stdio listen subscriptions that honor nothing - #3200
Open
adityajai119 wants to merge 1 commit into
Open
adityajai119 wants to merge 1 commit into
adityajai119 wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 30d17b6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@modelcontextprotocol/client
@modelcontextprotocol/codemod
@modelcontextprotocol/core
@modelcontextprotocol/server
@modelcontextprotocol/server-legacy
@modelcontextprotocol/express
@modelcontextprotocol/fastify
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Fixes #3199.
On HTTP,
createMcpHandler(createListenRouter) ends asubscriptions/listenstream right after sendingnotifications/subscriptions/acknowledgedwhenhonoredSubset(filter, capabilities)is empty, emitting the graceful-closeSubscriptionsListenResult(resultType: 'complete') and releasing the subscription slot (#2651).On stdio,
serveStdio(StdioListenRouter.serve()) sent the empty acknowledgement and still storedthis._subs.set(message.id, {})without emittingSubscriptionsListenResult. BecauselistenFilterAccepts({}, event)is always false, an empty-honored subscription on stdio could never deliver any notification, leftMcpSubscription.closedpending indefinitely, and permanently occupied one of the connection'smaxSubscriptionsslots.When
honoredis empty,StdioListenRouter.serve()now returns[ack, closeFrame]without registering the id in_subs, andserveStdiowrites both frames in order so stdio matches HTTP. Subscriptions that honor at least one notification type are unchanged.How Has This Been Tested?
packages/server/test/server/serveStdioListen.test.tscovering bothserveStdio(immediateacknowledged+completeresult,maxSubscriptions: 1slot remains free for a subsequent honored subscription, no duplicate close frame onhandle.close()) andStdioListenRouter.serve()directly; confirmed both fail on unmodifiedmainand pass with this change.s2in thehandle.close()active-subscriptions test inserveStdioListen.test.tsto request an advertised capability (toolsListChanged) so boths1ands2remain active until teardown.pnpm --filter @modelcontextprotocol/server test(55 files, 674 passed)pnpm --filter @modelcontextprotocol/test-e2e exec vitest run scenarios/subscriptions.test.ts(16 passed)pnpm --filter @modelcontextprotocol/test-integration test -- dualEraStdio(3 passed)pnpm run lint:all,pnpm --filter @modelcontextprotocol/server check, andpnpm --filter @modelcontextprotocol/server buildBreaking Changes
None.
Types of changes
Checklist
AI-assisted: drafted with an AI coding agent; I reviewed the diff and ran the tests above locally.