Repository navigation
Conversation
… validation
A tool with an outputSchema made callTool({ allowInputRequired: true }) throw on the
first round, because the intermediate input_required result has no structuredContent.
Validate only the completed result.
Fixes modelcontextprotocol#3216
🦋 Changeset detectedLatest commit: cf2455b The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@modelcontextprotocol/client
@modelcontextprotocol/codemod
@modelcontextprotocol/core
@modelcontextprotocol/server
@modelcontextprotocol/server-legacy
@modelcontextprotocol/express
@modelcontextprotocol/fastify
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3216
In manual mode,
callToolthrew on the first round for a tool with anoutputSchema, because theinput_requiredresult has nostructuredContentyet. The output check now skips that intermediate result and still validates the completed one from the retry.Tests: added a case to
inputRequiredEngine.test.tsthat fails on main with the error from the issue and passes with the fix.vitest run test/client/inpackages/clientpasses, apart from the four tests that builddistfirst (they needpnpmon PATH, which my sandbox lacks). Prettier and ESLint are clean on the changed lines; I didn't run the full typecheck.