Skip to content

move reauth prompt to before action to prevent state loss - #8383

Merged
Prospector merged 2 commits into
mainfrom
prospector/reauth-before-action
Nov 19, 2026
Merged

Prospector merged 2 commits into
mainfrom
prospector/reauth-before-action

Conversation

@Prospector

Copy link
Copy Markdown
Member

No description provided.

@github-actions

github-actions Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Note

This changelog has been baked. Any further edits will not be reflected.

Pull request changelog

App

Added

Changed

Deprecated

Removed

Fixed

Security

Website

Added

Changed

  • Moved re-authentication prompt to before you perform actions so your state is not lost when you go to save.

Deprecated

Removed

Fixed

Security

Hosting

Added

Changed

Deprecated

Removed

Fixed

Security

@mergify

mergify Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

This pull request is merged.

@greptile-apps

greptile-apps Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 4/5

[Medium impact] The PR changes when users reauthenticate across several privileged website workflows.

Fix the repeated OAuth sign-in before merging.

Summary

Moves reauthentication ahead of sensitive forms and confirmation dialogs to avoid losing entered information.

  • Privileged actions ask for reauthentication before forms open.
  • The profile username stays locked until reauthentication succeeds.

One blocking issue remains: OAuth-only users repeatedly return to sign-in instead of opening the guarded forms.

Reviews (1) · Last reviewed commit: "move reauth prompt to before action to p..." · Reviewed by Greptile

Comment thread apps/frontend/src/composables/reauth.ts Resolved
@github-actions

github-actions Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Frontend previews

Last deployed commit is 443b3fe3e2d362757c2d344ece392196f336c032

Persistent

Environment URL
staging https://pr-8383.frontend-staging.rinth.dev
production https://pr-8383.frontend.rinth.dev
storybook https://pr-8383-storybook.modrinth.workers.dev

Latest commit

Environment URL
staging https://e27e84b1.frontend-staging.rinth.dev
production https://bb1d8bad.frontend.rinth.dev

@Prospector
Prospector merged commit c8a42e3 into main Nov 19, 2026
15 checks passed
@Prospector
Prospector deleted the prospector/reauth-before-action branch November 19, 2026 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant