Repository navigation
Conversation
mhsmith
commented
Nov 14, 2026
| build_wheels: | ||
| if: github.repository == 'numpy/numpy-release' | ||
| name: BLD > ${{ matrix.python }}-${{ matrix.buildplat[1] }}-${{ matrix.buildplat[2] }} | ||
| name: ${{ matrix.python }}-${{ matrix.buildplat[1] }} ${{ matrix.buildplat[2] }} |
Author
There was a problem hiding this comment.
Shortening the name makes the web UI much more readable, especially when expanding the matrix in the flowchart.
| - name: Pyodide setup | ||
| if: ${{ matrix.buildplat[1] == 'pyodide_wasm32' }} | ||
| run: | | ||
| echo "CIBW_PLATFORM=pyodide" >> "$GITHUB_ENV" |
Author
There was a problem hiding this comment.
I removed this variable because it's unnecessary when using the only argument.
| uses: pypa/cibuildwheel@f9b966cfadf4109556cadc5bb39ddb72d0ce664e # v4.3.5 | ||
| env: | ||
| CIBW_BUILD: ${{ matrix.python }}-${{ matrix.buildplat[1] }} | ||
| SRC: ${{ github.workspace }}/numpy-src |
Author
There was a problem hiding this comment.
SRC was only used in one place in cibuildwheel.toml, where I've replaced it with cibuildwheel's built-in {package} syntax.
| NUMPY_SRC_DIR="${1:-$PWD}/numpy-src" | ||
|
|
||
| PROJECT_DIR="${1:?}" | ||
| NUMPY_SRC_DIR="${2:?}" |
Author
There was a problem hiding this comment.
I changed NUMPY_SRC_DIR to a command-line argument, to make it more convenient to run cibuildwheel locally against an arbitrary NumPy checkout.
andyfaff
reviewed
Nov 14, 2026
| - [windows-2022, win_amd64, ""] | ||
| - [windows-11-arm, win_arm64, ""] | ||
| - [ubuntu-24.04, android_arm64_v8a] | ||
| - [ubuntu-24.04, android_x86_64] |
Member
There was a problem hiding this comment.
Hold on, what's with the two entries for iOS and android?
I can't remember that being discussed.
2 of 3 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was proposed 2 weeks ago on the mailing list and received no objections.
Marked as draft pending the resolution of: