Skip to content

BLD: Add Android and iOS wheels - #86

Draft
mhsmith wants to merge 5 commits into
numpy:mainfrom
mhsmith:android-ios
Draft

mhsmith wants to merge 5 commits into
numpy:mainfrom
mhsmith:android-ios

Conversation

@mhsmith

@mhsmith mhsmith commented Nov 14, 2026 •

Copy link
Copy Markdown

This was proposed 2 weeks ago on the mailing list and received no objections.

Marked as draft pending the resolution of:

@mhsmith mhsmith left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build_wheels:
if: github.repository == 'numpy/numpy-release'
name: BLD > ${{ matrix.python }}-${{ matrix.buildplat[1] }}-${{ matrix.buildplat[2] }}
name: ${{ matrix.python }}-${{ matrix.buildplat[1] }} ${{ matrix.buildplat[2] }}

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shortening the name makes the web UI much more readable, especially when expanding the matrix in the flowchart.

- name: Pyodide setup
if: ${{ matrix.buildplat[1] == 'pyodide_wasm32' }}
run: |
echo "CIBW_PLATFORM=pyodide" >> "$GITHUB_ENV"

@mhsmith mhsmith Nov 14, 2026 •

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed this variable because it's unnecessary when using the only argument.

uses: pypa/cibuildwheel@f9b966cfadf4109556cadc5bb39ddb72d0ce664e # v4.3.5
env:
CIBW_BUILD: ${{ matrix.python }}-${{ matrix.buildplat[1] }}
SRC: ${{ github.workspace }}/numpy-src

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SRC was only used in one place in cibuildwheel.toml, where I've replaced it with cibuildwheel's built-in {package} syntax.

NUMPY_SRC_DIR="${1:-$PWD}/numpy-src"

PROJECT_DIR="${1:?}"
NUMPY_SRC_DIR="${2:?}"

@mhsmith mhsmith Nov 14, 2026 •

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed NUMPY_SRC_DIR to a command-line argument, to make it more convenient to run cibuildwheel locally against an arbitrary NumPy checkout.

@mhsmith mhsmith changed the title Add Android and iOS wheels BLD: Add Android and iOS wheels Nov 14, 2026
- [windows-2022, win_amd64, ""]
- [windows-11-arm, win_arm64, ""]
- [ubuntu-24.04, android_arm64_v8a]
- [ubuntu-24.04, android_x86_64]

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hold on, what's with the two entries for iOS and android?

I can't remember that being discussed.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's discuss it in numpy/numpy#33334.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants