Repository navigation
Conversation
type('X', (3,), {}) raised the 'not an acceptable base type' error for
the non-type base, and formatting that message with %N crashed with an
UnsupportedSpecializationException. Compare the metaclasses first, as
CPython does, and reject a non-type base with 'bases must be types'.
Signed-off-by: Jeongseop Lim <jeongseop_lim@korea.ac.kr>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part of #1291 (item 2).
TypeNode.calculateMetaclasschecks that each base is an acceptable base type before it compares metaclasses, and raisesTYPE_IS_NOT_ACCEPTABLE_BASE_TYPEwith%Nfor a base that is not a type. Formatting that message throwsUnsupportedSpecializationException, so reading the message ends the process. CPython's_PyType_CalculateMetaclasscompares the metaclasses first and rejects a non-type base later withbases must be types.AS-IS
TO-BE
(matching CPython)
Changes
calculateMetaclass, run the metaclass comparison over all bases first, then reject a base that is not a type withbases must be typesand an unacceptable type as before.BASES_MUST_BE_TYPEStoErrorMessages.tests/test_type.py.Testing
mx python-jvmon darwin-aarch64, thenmx graalpytestontest_type.py(the new test fails on the unpatched build and passes with the fix) and the taggedtest_types(107 passed).mx python-checkcopyrights,mx eclipseformatandmx checkstyleare clean.