Repository navigation
[Deps] TypeScript 7.0.2 everywhere (drop native-preview), esbuild 0.28.2 - #1302
Merged
Merged
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
…ywhere tsgo scripts now use the typescript@7.0.2 tsc each package already declares. Root scripts that need the JS compiler API import @typescript/typescript6 explicitly; the root typescript alias stays on TS 6 for typescript-eslint's hoisted dependencies.
cursor
Bot
force-pushed
the
cursor/deps-typescript-7-d3d2
branch
from
November 21, 2026 08:23
a9a2fcf to
828b39a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Moves every compile and typecheck onto the stable TypeScript 7 native compiler and removes the
@typescript/native-previewdev build. TS 6 stays only where a tool needs the JavaScript compiler API. Also bumps esbuild, whose new versions are trivially compatible with how this repo uses it.Versions
@typescript/native-preview(root, providedtsgo)tscused bydev/check-typesin core, editor, ui, geometry-script, viewer, nodes, mcp, ifc-convertertsgofrom the July dev build (indevand somecheck-types)tscfromtypescript@7.0.2(already declared by each package)typescriptnpm:@typescript/typescript6@6.0.2@typescript/typescript6(root, core)@repo/eslint-config→typescriptesbuild(root)End state for TS 7, and why one TS 6 alias stays
typescript@7.0.2has no classic JS API. Its root export is onlylib/version.cjs, plustypescript/unstable/*IPC APIs. Its only binary istsc(the Go compiler), and there is notsgoand notsserver.js.@typescript/native-previewis no longer needed. Every package already depends ontypescript@7.0.2, so thetsgo …scripts now calltsc …, which resolves to that package's own TS 7 binary.ts.createSourceFile,forEachChild, …) now import@typescript/typescript6directly, asscripts/fix-node-esm-imports.tsandpackages/corealready did. The affected scripts arei18n-literals(.test).ts,i18n-codemod.tsandcheck-render-bundle.ts. They no longer rely on the root alias.typescript→@typescript/typescript6alias stays, only for typescript-eslint. typescript-eslint 8.72 requirestypescript >=4.8.4 <6.1.0(used bypackages/uieslint). With bun's hoisted linker, its transitive dependencyts-api-utilsis hoisted to the root and resolves the roottypescript. I tried pointing the root at7.0.2. ESLint then crashed ints-api-utils(Cannot read properties of undefined (reading 'Intrinsic')). Declaringts-api-utilsin@repo/eslint-configdid not change bun's hoisting, and bun has no nested overrides. The alias can go once typescript-eslint supports TS 7, or if the repo moves to bun's isolated linker. That is out of scope here.Breaking changes and code changes
moduleResolution: node10,baseUrlpath lookup and ES5 targets): source and tsconfigs needed no changes.turbo check-typesandturbo buildwere already running TS 7.0.2tscfor builds, and they pass with the stable compiler for the packages that usedtsgo. The only code change is the explicit@typescript/typescript6import in the four scripts above, with Biome's import reordering.binaryloader useUint8Array.fromBase64and raises the minimum OS to Linux 3.2 and macOS 12. 0.28 adds integrity checks to the fallback binary download and moves to Go 1.26. The repo only calls thebuild()JS API inscripts/check-render-bundle.ts(plugins, splitting, metafile, nobinaryloader), so no code changes were needed.@lingui/clialready requiresesbuild ^0.28.1and now shares the root copy.bun.lock: removes the native-preview packages and moves esbuild with its platform binaries to 0.28.2. No other dependency changed.How to test
bun install --frozen-lockfilebun run check: no errors.bun run check-types: all 14 turbo tasks pass (run locally with--force).bun run test: turbo tests and root script tests pass (81 root tests).bun run build && bun run check:render-bundle: the build succeeds and the render-boundary check passes on esbuild 0.28.2.bun run i18n:check: catalogs in sync (uses the TS 6 API throughi18n-literals.ts).cd packages/ui && bun run lint: ESLint with typescript-eslint passes, as onmain.Screenshots / screen recording
N/A — non-visual change
Checklist
bun devbun checkto verify)mainbranchNote
Medium Risk
Swaps the primary typecheck/build dev loop from experimental
tsgoto stable TS 7tscand upgrades esbuild across the build pipeline; low runtime risk but could surface compiler or bundle-check differences.Reviewed by Cursor Bugbot for commit c13bdd8. Bugbot is set up for automated code reviews on this repo. Configure here.