Skip to content

Carrier ports take what pathsim connects to them - #362

Merged
milanofthe merged 1 commit into
mainfrom
fix/carrier-channel-rule
Nov 18, 2026
Merged

milanofthe merged 1 commit into
mainfrom
fix/carrier-channel-rule

Conversation

@milanofthe

Copy link
Copy Markdown
Member
  • busWiringProblem checks a wire into a carrier port as Connection._validate_dimensions does: one signal per channel, keys compared only where the signal and the channel both have one. Signals from plain ports, channels named by position and signals through subsystem ports have none.
  • The resolution of signal sources moves from expandBuses into analyzeBuses, so the expansion and the check share it.
  • channelKey / channel_key decide in one place whether a channel has a key.
  • tests/fixtures/bus_expansion.json gets wires into carrier ports with the verdict of pathsim: the Python test builds them in pathsim, the TS test checks busWiringProblem against it.

Closes #356

@milanofthe
milanofthe merged commit 9a0588e into main Nov 18, 2026
4 checks passed
@milanofthe
milanofthe deleted the fix/carrier-channel-rule branch November 18, 2026 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ports from block instances, and pathsim's channel rule for carrier wiring

1 participant