Repository navigation
Carrier ports take what pathsim connects to them - #362
Merged
Merged
Conversation
… both channels have one
7 of 77 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
busWiringProblemchecks a wire into a carrier port asConnection._validate_dimensionsdoes: one signal per channel, keys compared only where the signal and the channel both have one. Signals from plain ports, channels named by position and signals through subsystem ports have none.expandBusesintoanalyzeBuses, so the expansion and the check share it.channelKey/channel_keydecide in one place whether a channel has a key.tests/fixtures/bus_expansion.jsongets wires into carrier ports with the verdict of pathsim: the Python test builds them in pathsim, the TS test checksbusWiringProblemagainst it.Closes #356