Repository navigation
fix(PageSidebar): keep collapsed content out of the tab order - #12720
Sophran-fbj wants to merge 1 commit into
Conversation
Assisted-by: OpenAI Codex
|
No actionable comments were generated in the recent review. Walkthrough
ChangesCollapsed sidebar focus handling
Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix · Severity of issue fixed: Medium Suggested reviewers: Merge Risk:
|
What: Closes #12693
A collapsed
PageSidebaris hidden from assistive technology, but keyboard users could still tab into links and controls rendered inside it. Set nativeinerton the collapsed sidebar using PatternFly's existing React compatibility helper. Expanding the sidebar restores keyboard access. The context-selector demo now relies on the sidebar for this behavior.The Cypress regression uses a native Tab keypress at 390 px. On upstream
main, focus went to the collapsed sidebar link. With the fix, it moves to the main-content link and can reach the sidebar link again after expansion.Validation
yarn test:integration --browser <electron|chrome> --spec 'cypress/integration/page.spec.ts,cypress/integration/pagemanagedsidebarclosed.spec.ts'— 5 passed in each browser.yarn exec jest --runInBand --testPathPattern 'components/(Page|Nav)/__tests__'— 171 passed across 17 suites.yarn lint:all,yarn build:esm,yarn build:cjs,yarn build:subpaths,yarn build:single:packages, andyarn build:integrationpassed. I used the published@patternfly/react-tokens@6.7.0artifacts for the local Windows build after interrupting slow token generation.Additional issues: PatternFly Page design documentation.
Assisted-by: OpenAI Codex
Summary by CodeRabbit