Skip to content

Fix: sync issue triage labels, skip unchanged labels and add CI - #8

Merged
Rom1-B merged 7 commits into
mainfrom
fix_sync_labels
Nov 17, 2026
Merged

Rom1-B merged 7 commits into
mainfrom
fix_sync_labels

Conversation

@Rom1-B

@Rom1-B Rom1-B commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Checklist before requesting a review

  • I have performed a self-review of my code.

Description

  • It fixes #N/A
  • label-commenter-config.yml acts on the invalid, support and feature suggestion labels, but nothing created them, so labelling an issue in a repository lacking them was impossible.
  • sync/labels.json now defines them: invalid keeps the GitHub default, support and feature suggestion use the colors of pluginsGLPI/fields.
  • The label comparison always failed because gh --jq sorts keys and returns a null empty description, so every run updated every label of every repository; both sides are now normalized and unchanged labels are skipped.
  • A new ci.yml workflow lints every workflow (including the synced ones) with actionlint, sync.sh with shellcheck and validates sync/*.json; on pull requests it also runs sync.sh in dry run with a read-only app token, so the changes it would apply to every synced repository are visible before merge.

@Rom1-B
Rom1-B requested a review from stonebuzz November 13, 2026 13:18
@Rom1-B Rom1-B changed the title Fix: sync issue triage labels and skip unchanged labels Fix: sync issue triage labels, skip unchanged labels and add CI Nov 13, 2026
Comment thread .github/workflows/ci.yml Outdated
sync-dry-run:
name: "Sync dry run"
# Fork pull requests get no secrets
if: github.event_name == 'pull_request' && github.event.pull_request.head.repo.full_name == github.repository

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this be an issue with Dependabot being enabled for this repository's GitHub Actions (.github/dependabot.yml)? The new SHA pins in ci.yml would trigger Dependabot PRs. Since these PRs originate from same-repository branches, the workflow runs; however, Dependabot-triggered workflows only have access to Dependabot secrets. As a result, SYNC_APP_PRIVATE_KEY would be empty, causing create-github-app-token to fail and every Dependabot PR to end up with a failing "Sync dry run" check.

if: >-
  github.event_name == 'pull_request'
  && github.event.pull_request.head.repo.full_name == github.repository
  && github.actor != 'dependabot[bot]'

@Rom1-B
Rom1-B merged commit e3d5fdc into main Nov 17, 2026
2 checks passed
@Rom1-B
Rom1-B deleted the fix_sync_labels branch November 17, 2026 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants