Repository navigation
Conversation
There was a problem hiding this comment.
inc/model.class.php:1503: TCPDF renders the PDF title as plain text, htmlescape() shows entities literally (R&D). Remove it and the tags.
inc/modelcsv.class.php:129: escaped headers ('-serial) no longer match in isHeaderCorrect(), the sample file is rejected on import. Don't escape the sample headers.
|
Thanks! PDF title: removed |
Lainow
left a comment
There was a problem hiding this comment.
I don’t think this is intentional, so, to be on the safe side: it appears that checkRight(READ) returns a 403 for profiles that only have the USE permission.
Checklist before requesting a review
Description
Several small fixes in the injection workflow and the CSV/PDF exports.
Fix
ajax/dropdownChooseField.php,ajax/dropdownMandatory.php): use the model right, as for the model form that calls them.escapeCsvFormula()to the error file headers and to the model sample file (now written withfputcsv).inc/with the query builder, and drop the unusedPluginDatainjectionProfile::cleanProfiles().Tests
AdditionalInformationTest: additional information values are output as text.ClientInjectionEscapeCsvFormulaTest/ClientInjectionWriteErrorsCsvTest: headers and extra leading characters are handled.