Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Description
csp_compliant=> true in plugin_version_metabase().Converted patterns
inc/dashboard.class.php(PluginMetabaseDashboard::showForCentral()):on_changeoption ofDropdown::showFromArray()replaced byadd_data_attributes(data-metabase-dashboard-switch=helpdeskorcentral). Same behaviour: helpdesk reloads the page with?uuid=, Central callsreloadTab("uuid=<value>").public/metabase.js: new delegatedchangelistener onselect[data-metabase-dashboard-switch]implementing the two behaviours above.setup.php(plugin_version_metabase()):csp_compliant=> true.CHANGELOG.md: Unreleased entry.No
javascript:URLs, no<script>tags printed from PHP, noHtml::addConfirmationOnAction(),Html::link()orconfirmactionusage were found.Blocked by
PLUGIN_METABASE_MIN_GLPI, currently 11.0.0) must be bumped to the first CSP-enabled 11.0 release before merging, otherwise the dashboard selector silently stops reacting on older GLPI versions.Manual test checklist
Keep the browser console open: CSP violations show as
Refused to execute inline event handlerorRefused to execute inline script.?uuid=<selected>and show the selected dashboard.