Repository navigation
Conversation
…eading lines in order tabs
Herafia
requested review from
a team,
Mary-Clb,
Rom1-B,
RomainLvr and
jdurand-teclib
and removed request for
a team and
jdurand-teclib
November 17, 2026 13:11
Rom1-B
requested changes
Nov 17, 2026
Rom1-B
left a comment
Contributor
There was a problem hiding this comment.
The order detail and associated items tabs still read each line through getReceptionStatus():
diff --git a/inc/link.class.php b/inc/link.class.php
@@ -294,7 +294,6 @@ class PluginOrderLink extends CommonDBChild
$PluginOrderOrder_Item = new PluginOrderOrder_Item();
$PluginOrderReference = new PluginOrderReference();
- $PluginOrderReception = new PluginOrderReception();
@@ -417,7 +416,7 @@ class PluginOrderLink extends CommonDBChild
- $entry['status'] = $PluginOrderReception->getReceptionStatus($detailID);
+ $entry['status'] = PluginOrderReception::getReceptionStatusLabel((int) $data["states_id"]);
diff --git a/inc/order_item.class.php b/inc/order_item.class.php
@@ -1185,6 +1185,7 @@ class PluginOrderOrder_Item extends CommonDBRelation
$table . '.price_ati',
+ $table . '.states_id',
],
@@ -1259,7 +1260,7 @@ class PluginOrderOrder_Item extends CommonDBRelation
- $entry['status'] = $reception->getReceptionStatus($data["IDD"]);
+ $entry['status'] = PluginOrderReception::getReceptionStatusLabel((int) $data["states_id"]);
Rom1-B
approved these changes
Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
glpi_plugin_order_orders_items.plugin_order_orders_idandglpi_plugin_order_orders.budgets_id(install and migration); over-budget check in one query instead of one SUM per order of the budget; reception tab uses the loaded line status instead of reading each line twice; bills tab and budget tab read bills, names and prices once; noisActivated()at initSQL Queries
glpi_pluginsper requestResponse Times