Repository navigation
Conversation
Tracks contract revision 61610853b4 of polymorfa/polymorfa#887. Renames the --owner value, profile key, principal type, output fields, SDK credential and client names, help text, README, skills and tests. No aliases or shims. Regenerates contracts/cli-reference.json.
|
Warning Review limit reachedThe included review limit has been reached and this organization has disabled usage-based review continuation. Wait for reviews to reset or ask a billing admin to change After included review limits.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Next included review available in 5 minutes. View limit details
|
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5f63032bb5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Rename the newsletter observation fixture to teamId, sync the Business account-mode contract to API a3db53e74c (team wording), regenerate the CLI reference, and use credential fixtures with valid opaque shapes so tests run against the SDK source that validates them.
|
@codex review |
|
@codex security review |
|
Codex Review: Didn't find any major issues. 👍 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
Dependency status, 2026-11-17 A renamed SDK now exists on the preview channel:
I have not pushed the preview pin, and I have not changed the guard. To land this PR, one of these is needed:
CLI publication is already refused today ("SDK publication with matching API acceptance must finish first"), independent of this PR. |
Renames "organization" to "team" across the CLI. Greenfield: no deprecated aliases or shims.
Tracks contract revision
61610853b4of polymorfa/polymorfa#887.Depends on the polymorfa/sdks team-rename PR (
organizationApiKey→teamApiKey,OrganizationClient→TeamClient,organizations→teams,validateOrganizationApiKey→validateTeamApiKey,ClientInstance<'organization'>→ClientInstance<'team'>).Must merge after #887 and the SDK PR.
package.jsonstill pins the current published@polymorfa/sdk; it must be bumped to the SDK release that carries the rename before this merges. Nothing is published here.Renamed surface
--owner organization→--owner team(every command that takes--owner; value choices are nowproject|team)organization→teamprincipalTypeorganization_key→team_key,organizationId→teamId, resource ownerorganization→teamorganizationId→teamIdorganizationApiKey→teamApiKeyorg_*→team_*POLYMORFA_API_KEY), so none changed.Kept (not the tenant):
message send contact --organization(vCardORG:company field), npm/GitHub organization wording ininternal/npm-prerelease.md,.orgURLs.Reference artifact
contracts/cli-reference.jsonregenerated (npm run docs:reference, 381 commands) for the docs app'ssync-cli-reference.mjs.Five-part assessment
teamId,team_key,bansafe_team_suspended,teamsroutes through the SDK.contracts/abprops-capabilities.jsonupdated for the renamed error code.docs/and the reference artifact. The public Mintlify CLI reference in polymorfa/polymorfa syncs fromcontracts/cli-reference.jsonafter this merges; not yet synced.Verification
tsctypecheck,eslint .,prettier --check: cleanvitest run: 1169/1169 pass (with--maxWorkers=3 --testTimeout=30000; the default run shows load-related 5s timeouts on a busy machine)npm run docs:reference: regeneratedverify:browser,verify:bundled-runtime,npm pack,audit:prod, and a build against the real renamed SDK release.\borg(anization)?s?\b|orgId|organizationId|organization_api_key|ORG_KEY|--org\b: remaining hits are only the vendor/non-tenant items listed above plus.orgURLs (registry.npmjs.org).Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.Contract and dependency status (2026-11-12)
devasa3db53e74c6e24507ca01e2ff6ecba19358422c7. Its specs are identical to contract revisionf180dc1ee2.mainas6f4afba13d48ba55356def32b6aa1aa2f169f5a7.@polymorfa/sdk, which still exports the organization names (validateOrganizationApiKey,Client<'organization'>). No SDK release with the team names exists yet. The nightly publish (publish-dev.yml) builds only after staging acceptance passes for the API commit pinned in the SDK'scontracts/source.json, which needs #887 deployed to staging. Once a nightly0.x.y-dev.<timestamp>is published, bump the exact@polymorfa/*versions here, rerun CI, and merge.Current state (2026-11-16)
origin/mainat088ea9e522a3138134bfe336cdbc1cfdbb3f550d(ordinary merge, no conflicts). Head:a79c8731953c82727eb251891577d0cce0f5b49f.mainadded:organizationId→teamIdin the newsletter-observation test;contracts/business-account-modes.jsonre-synced to APIa3db53e74c(team wording,bansafe_team_suspended);contracts/cli-reference.jsonregenerated (390 commands).pmfa_/pmfa_pt_, canonicalpmfa_ct_), which SDK source validates; the expected SDK wording ("opaque format", "team keys") replaces the old text.mainatccc8eebab8(includes #3726f4afba13d), built locally and linked intonode_modulesonly (not committed): typecheck,eslint .,prettier --check,npm run build,cli-reference --check,verify:browser,npm pack --dry-run,audit:prodand script tests pass.vitest run: 1233/1236 pass. The 3 failures (campaign-experiments.test.ts, missingTemplaterow in expected output) also fail on unmodifiedorigin/mainand are unrelated to the rename.verify:bundled-runtimeinstalls the published SDK and fails withvalidateTeamApiKeymissing, as expected until a renamed SDK is published.@polymorfa/sdkcontaining Rename organization to team across the SDKs sdks#372. The SDK nightly is refused daily by the release-gate hold ("Guest calls are held from publication until API source acceptance"); a manual preview channel is pending in Add manual SDK preview releases without API acceptance sdks#376. The CLI's release scripts accept only an accepted nightly (-dev.<digits>, npmdevtag, staging receipt) or stable release; a preview version is not accepted for CLI publication. Bump the exact SDK version inpackage.json/package-lock.jsononce a suitable release exists.validateTeamApiKey,Client<"team">,ClientOwner).