Repository navigation
Conversation
smartQuoteMark() treated a value as an identifier when cssesc returned it
unchanged. That holds for "" and "-" too, so setValue("", { smart: true })
wrote [data-foo=], which this parser rejects since postcss#352, and "-" wrote
[data-foo=-], which browsers reject. Both now get a quote mark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attribute#smartQuoteMark()decides that a value with no quotes in it is an identifier whencssesc(v, { isIdentifier: true })returns it unchanged. Two values pass that check without being identifiers:Both now get a quote mark, picked the same way as any other value that needs quotes (the
quoteMarkoption, then the current quote mark, then").getQuotedValue({ smart: true })follows, since it uses the same method. Real identifiers (a,-a,--,_,é) still stay unquoted.I kept the change in
smartQuoteMark()and did not touch the vendoredcssesc, since its tests pin it to cssesc 3.0.0 output.Tests: 7 new cases in
attributes.mjs(empty and-with eachquoteMarkoption, pluspreferCurrentQuoteMark) fail before the change and pass after; each one also checks that the output parses back to the same value. One control test checks identifiers stay unquoted.npm testpasses (1,092 tests, lint, typecheck, coverage).oxfmt --checkis clean for the changed files.