Repository navigation
Conversation
This reverts commit 7894f00.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is all serving up data that already existed. Adding the reviewers, committers, target version, tags, wiki/git links, and created/modified dates fills out the patches with all the fields on the page.
There's also a single-patch /patches/ endpoint, returning the same patch object as the commitfest listing with its threads included.
Then I added a per-patch /history endpoint to cover the history table we already have.
Finally, a global view into the history across all patches, which gives us the ability to see what's changed since a specific date. I went with cursor pagination, since this acts more like a feed than something you'd select individual pages from.
One pattern this introduces is a standard JSON 400 error envelope
{error: '<message>' }, which /patches/ also uses for its 404. Right now our error handling has JSON endpoints returning HTML 404s and is pretty inconsistent throughout. I can polish that up, but I'd want to do it in a separate PR.