Repository navigation
Conversation
sobolevn
force-pushed
the
issue-101703-bytesobject
branch
from
November 14, 2026 10:54
ead4b04 to
6122dec
Compare
sergey-miryanov
approved these changes
Nov 14, 2026
sergey-miryanov
left a comment
Contributor
There was a problem hiding this comment.
LGTM.
Small nitpick: WDYT about moving assert(1 <= len && len < (Py_ssize_t)sizeof(buffer)); to the macro too?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.