Repository navigation
Conversation
Reviewers go through proposals one at a time, fewest votes first. The screen shows the proposal, the speaker, the other reviewers' votes and the community ranking, with a vote bar pinned at the bottom: one button per score option plus No vote, a comment, Previous and Skip for now. The current proposal and hidden tags live in the URL, so a link opens the same proposal.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Adds Focus Mode to the beta CFP review pages. Reviewers step through proposals one at a time with a vote bar, votes and speaker cards, a tag filter, and URL state. Issues
Tests. There are no frontend tests for the history/back/skip logic or the URL-state parsing. Both are easy to cover as unit tests. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## claude/cfp-review-api #4869 +/- ##
======================================================
Coverage 92.66% 92.66%
======================================================
Files 367 367
Lines 11098 11098
Branches 959 959
======================================================
Hits 10284 10284
Misses 689 689
Partials 125 125 🚀 New features to boost your workflow:
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #4868. Part 3 of 3 of the new CFP review pages (beta).
What
Focus Mode, the first real screen of My review: reviewers go through proposals one at a time.
?proposal=…&exclude=…), so a link opens the same proposal.Empty states: "You've reviewed everything" with a link to the Shortlist, a message when the session has no score options, and a note when the community ranking hasn't been generated.
Testing
pnpm buildproduces bothreview-beta-*.htmlpages. Biome is clean. TypeScript isn't installed incustom_admin, so there's no type check.?proposal=<id>directly;