Skip to content

Render about template chrome inside main landmark (#14605) - #15404

Open
jay23606 wants to merge 2 commits into
quarto-dev:mainfrom
jay23606:pr-go-simple/14605
Open

jay23606 wants to merge 2 commits into
quarto-dev:mainfrom
jay23606:pr-go-simple/14605

Conversation

@jay23606

Copy link
Copy Markdown

When an about page uses a built-in template and falls back to main.content, the post-processor passed <main>'s outerHTML into the template and then replaced <main> with the output. The title block, image and links therefore ended up outside <main>, and the title <header> became a second banner.

Change: in website-about.ts, when the about element is main.content, pass its innerHTML as about.body and render the template into <main> itself. The explicit-id path is unchanged.

Tests: added fixture tests/docs/websites/issue-14605 and smoke test tests/smoke/website/issue-14605-about-in-main.test.ts, which asserts main #title-block-header and main .about-links exist after render.

Not run here: the smoke test and the existing website test suite were not run locally, because the dev environment's dependencies were not installed and I was told not to install them. CI should exercise them.

Tests not run here: quarto test smoke/website/issue-14605-about-in-main.test.ts (not run: dependencies not installed locally; CI to run), tests/smoke/website/ suite (not run: same reason)

Fixes #14605

🤖 Generated with Claude Code

Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
@posit-snyk-bot

posit-snyk-bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Collaborator

✅ Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues
✅ Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
@jay23606
jay23606 marked this pull request as ready for review November 20, 2026 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

a11y: all about templates render the title block, image, and links outside <main>

2 participants