Repository navigation
chore: describe component props in their source - #1014
Open
rohanchkrabrty wants to merge 1 commit into
Open
rohanchkrabrty wants to merge 1 commit into
rohanchkrabrty wants to merge 1 commit into
Conversation
Write a one-line JSDoc for each prop in the component source, with `@default` where the component sets one, so the docs tables can read the types in place of the hand-written props.ts files. Parts that pass fixed props to Flex, Text, IconButton or Select.Trigger redeclare those props in a local interface with their own `@default`, for example Dialog.Header `justify` and `align`. Props that only a union branch or a wrapped library declares get an Apsara declaration, and data-view exports `ViewSpec`. Types and comments only, no runtime change.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Important Review skippedToo many files! This PR contains 153 files, which is 53 over the limit of 100. To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry.
|
This was referenced Nov 17, 2026
commit: |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@defaultwhere the component sets one. The docs tables read these in place of the hand-writtenprops.tsfiles.@default, for examplejustifyandalignonDialog.Header.ViewSpec.