Skip to content

fix: [button] set the small size height to 24px - #1017

Merged
rohanchkrabrty merged 1 commit into
mainfrom
fix/button-small-height
Nov 18, 2026
Merged

rohanchkrabrty merged 1 commit into
mainfrom
fix/button-small-height

Conversation

@rohanchkrabrty

Copy link
Copy Markdown
Contributor

Summary

  • Set height: var(--rs-space-7) (24px) on the small Button size.
  • The small size was 22px: 4px vertical padding plus a 14px line height. Figma sets it to 24px.
  • The small Button now has the same height as the small Input.

The small size was 22px tall (4px padding + 14px line height). Figma sets it to 24px, the same as the small Input.
@vercel

vercel Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
apsara Ready Ready Preview Nov 17, 2026 12:27pm UTC

@pkg-pr-new

pkg-pr-new Bot commented Nov 17, 2026

Copy link
Copy Markdown

Open in StackBlitz

pnpm add https://pkg.pr.new/@raystack/apsara@1017

commit: 5aeb3c2

@coderabbitai

coderabbitai Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The .button-small rule now sets its height to var(--rs-space-7).

Suggested reviewers: shreyag02, rohilsurana

Merge Risk: Minimal · up to 5aeb3

This sets the small Button height to 24px so it matches the small Input. The change is a single style declaration with no identified regression risk, and it is ready to merge.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the main change: the small Button size height is set to 24px. The raw summary says the .button-small rule now sets height to var(--rs-space-7), which is 24px per the description. The t…
Description check Passed The description is directly related to the changeset. It states that the small Button height is set to var(--rs-space-7) (24px), gives the previous height breakdown (4px padding plus 14px line height,…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the main change: the small Button size height is set to 24px. The raw summary says the .button-small rule now sets height to var(--rs-space-7), which is 24px per the description. The title is short and specific. It uses the conventional 'fix:' prefix, which matches the change's purpose of correcting the height to match Figma.

Full details: Description check

Explanation

The description is directly related to the changeset. It states that the small Button height is set to var(--rs-space-7) (24px), gives the previous height breakdown (4px padding plus 14px line height, 22px total), and explains the goal of matching the small Input height. This matches the one-line CSS change in button.module.css.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: a609f429-466e-4a08-be6e-602abe01a4a2
Commits

Reviewing files that changed from the base of the PR and between 5ee0994 and 5aeb3c2.

Files selected for processing: 1

  • packages/react/components/button/button.module.css

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@rohanchkrabrty
rohanchkrabrty merged commit b53662f into main Nov 18, 2026
8 checks passed
@rohanchkrabrty
rohanchkrabrty deleted the fix/button-small-height branch November 18, 2026 06:34

This branch was successfully deployed

1 active deployment
Preview — 5aeb3c21 Deployed Nov 17, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants