Skip to content

feat(webapi): isolate History and Location features [Codex] - #413

Open
jderochervlk wants to merge 3 commits into
mainfrom
feat/isolate-history-location
Open

jderochervlk wants to merge 3 commits into
mainfrom
feat/isolate-history-location

Conversation

@jderochervlk

@jderochervlk jderochervlk commented Nov 16, 2026 •

Copy link
Copy Markdown
Collaborator

React's DOM bindings need element, history, and location types, but History and Location currently belong to the Window feature. Selecting those types therefore also compiles the broader Window dependency graph.

Add independent WebAPI.History and WebAPI.Location features and move their source files into their own directories. History depends only on the standard library; Location depends on core DOM. Window includes both features, preserving existing module names and type identities.

Consumers can now select WebAPI.DOMNodes, WebAPI.History, and WebAPI.Location without enabling Window. In the rescript-react experiment, this reduces the WebAPI source-module count from 229 with Window to 59.

The change also aligns the compiler, prerelease peer range, consumer checks, and documentation with ReScript 13.0.0-alpha.7. An existing ImageData fixture uses the explicit typed-array coercion required by that compiler. Formatter normalization is isolated in a second commit so it can be reviewed separately from the feature split.

The documentation renderer now handles the compiler's structured parameter metadata. Full signatures remain visible when richer type details cannot be rendered as links.

Further separation of shared DOM types from Element operations is intentionally outside this PR and will build on this change.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-16T18:48:39.165580Z 625b868 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants