Repository navigation
feat(webapi): isolate History and Location features [Codex] - #413
Open
jderochervlk wants to merge 3 commits into
Open
jderochervlk wants to merge 3 commits into
jderochervlk wants to merge 3 commits into
Conversation
jderochervlk
requested review from
brnrdog,
fhammerschmidt and
tsnobip
as code owners
November 16, 2026 18:42
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Nov 16, 2026
fhammerschmidt
approved these changes
Nov 16, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
React's DOM bindings need element, history, and location types, but History and Location currently belong to the Window feature. Selecting those types therefore also compiles the broader Window dependency graph.
Add independent
WebAPI.HistoryandWebAPI.Locationfeatures and move their source files into their own directories. History depends only on the standard library; Location depends on core DOM. Window includes both features, preserving existing module names and type identities.Consumers can now select
WebAPI.DOMNodes,WebAPI.History, andWebAPI.Locationwithout enabling Window. In the rescript-react experiment, this reduces the WebAPI source-module count from 229 with Window to 59.The change also aligns the compiler, prerelease peer range, consumer checks, and documentation with ReScript 13.0.0-alpha.7. An existing ImageData fixture uses the explicit typed-array coercion required by that compiler. Formatter normalization is isolated in a second commit so it can be reviewed separately from the feature split.
The documentation renderer now handles the compiler's structured parameter metadata. Full signatures remain visible when richer type details cannot be rendered as links.
Further separation of shared DOM types from Element operations is intentionally outside this PR and will build on this change.